[GitHub] [sling-org-apache-sling-event] joerghoh commented on pull request #19: Bump quartz from 2.2.0 to 2.3.2

[GitBox <gi...@apache.org>]

joerghoh commented on PR #19:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/19#issuecomment-1133645007

   We should not have a direct dependency to the quartz scheduler here, instead the sling scheduler bundle should expose all necessary features;quartz should be an implementation detail of the bundle, and it should not leak.
   
   I found that these references in the code towards quartz:
   * In [ScheduleInfoImpl](https://github.com/apache/sling-org-apache-sling-event/blob/59edcddc14e65f2c90f17df1402aee55b00c69a0/src/main/java/org/apache/sling/event/impl/support/ScheduleInfoImpl.java#L28) a ```CronExpression```  is used to validate that the expression is an actual valid cron expression.
   
   While we could actually trying to asses ourselves, if that expression is a valid cron expression I would favor an extension of the Scheduler API like ```static boolean isValidCronExpression (String expression)```, and internally it could implement it using a CronExpression. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org