You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Akins <ba...@web.turner.com> on 2005/08/18 15:55:57 UTC
mod_cache recall_body
Why do we pass request_rec to recall_headers, but not to recall_body.
We also always pass r->pool. How horrible would it be if the prototype
was changed to:
apr_status_t (*recall_body) (cache_handle_t *h, request_rec
*r,apr_bucket_brigade *bb);
I wanted to get r in recall_body so mod_disk_cache could honor
EnableMMap. open_entity can already be modified to honor EnableSendfile
fairly easily.
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
[PATCH] Re: mod_cache recall_body
Posted by Brian Akins <ba...@web.turner.com>.
Justin Erenkrantz wrote:
>
> I'd be fine with it matching store_body's prototype. (Which is what you
> have.) -- justin
>
Here's a patch that does this.
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
Re: mod_cache recall_body
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On August 18, 2005 9:55:57 AM -0400 Brian Akins <ba...@web.turner.com>
wrote:
> Why do we pass request_rec to recall_headers, but not to recall_body. We
> also always pass r->pool. How horrible would it be if the prototype was
> changed to:
>
> apr_status_t (*recall_body) (cache_handle_t *h, request_rec
> *r,apr_bucket_brigade *bb);
>
> I wanted to get r in recall_body so mod_disk_cache could honor EnableMMap.
> open_entity can already be modified to honor EnableSendfile fairly easily.
I'd be fine with it matching store_body's prototype. (Which is what you
have.) -- justin