You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "David Phillips (JIRA)" <ji...@apache.org> on 2009/01/05 23:11:44 UTC
[jira] Created: (HIVE-209) Enable assertions for unit tests
Enable assertions for unit tests
--------------------------------
Key: HIVE-209
URL: https://issues.apache.org/jira/browse/HIVE-209
Project: Hadoop Hive
Issue Type: Bug
Components: Testing Infrastructure
Reporter: David Phillips
We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-209) Enable assertions for unit tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-209:
-------------------------------
Attachment: hive-209.patch
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Assignee: Prasad Chakka
> Attachments: hive-209.patch, hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-209) Enable assertions for unit tests
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-209:
--------------------------------
Fix Version/s: 0.3.0
(was: 0.6.0)
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Assignee: Prasad Chakka
> Fix For: 0.3.0
>
> Attachments: hive-209.2.patch, hive-209.patch, hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-209) Enable assertions for unit tests
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660969#action_12660969 ]
David Phillips commented on HIVE-209:
-------------------------------------
This change to HiveConf.java
{noformat}
- HADOOPNUMREDUCERS("mapred.reduce.tasks", "1"),
+ HADOOPNUMREDUCERS("mapred.reduce.tasks", 1),
{noformat}
exposes an assertion in DynamicSerDeFieldList.java:
{noformat}
assert(field.type == TType.STOP);
{noformat}
Use this (happens with many other tests too): ant -Dtestcase=TestCliDriver -Dqfile=join1.q test
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Attachments: hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-209) Enable assertions for unit tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-209:
-------------------------------
Attachment: hive-209.2.patch
there was one another assert that was caught later. now all tests pass.
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Assignee: Prasad Chakka
> Attachments: hive-209.2.patch, hive-209.patch, hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HIVE-209) Enable assertions for unit tests
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao resolved HIVE-209.
-----------------------------
Resolution: Fixed
Fix Version/s: 0.2.0
Release Note: HIVE-209. Enabling asserts in tests. (Prasad Chakka via zshao)
Hadoop Flags: [Reviewed]
Thanks Prasad! Committed revision 732271.
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Assignee: Prasad Chakka
> Fix For: 0.2.0
>
> Attachments: hive-209.2.patch, hive-209.patch, hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-209) Enable assertions for unit tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka reassigned HIVE-209:
----------------------------------
Assignee: Prasad Chakka
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Assignee: Prasad Chakka
> Attachments: hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-209) Enable assertions for unit tests
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated HIVE-209:
--------------------------------
Attachment: hive-junit-assert.patch
Simple patch to enable assertions. It would be great if the core developers can fix the existing assertion failures.
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Attachments: hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-209) Enable assertions for unit tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661015#action_12661015 ]
Prasad Chakka commented on HIVE-209:
------------------------------------
These are 4 assertions I see that cause quite a few failures in TestCliDriver
org.apache.hadoop.hive.serde2.dynamic_type.DynamicSerDeFieldList.deserialize(DynamicSerDeFieldList.java:196)
org.apache.hadoop.hive.conf.HiveConf.getIntVar(HiveConf.java:154)
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.doPhase1GetAllAggregations(SemanticAnalyzer.java:189)
org.apache.hadoop.hive.ql.typeinfo.TypeInfoFactory.getPrimitiveTypeInfo(TypeInfoFactory.java:38)
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Attachments: hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-209) Enable assertions for unit tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661368#action_12661368 ]
Prasad Chakka commented on HIVE-209:
------------------------------------
another one here
org.apache.hadoop.hive.ql.typeinfo.StructTypeInfo.<init>(StructTypeInfo.java:78)
> Enable assertions for unit tests
> --------------------------------
>
> Key: HIVE-209
> URL: https://issues.apache.org/jira/browse/HIVE-209
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: David Phillips
> Assignee: Prasad Chakka
> Attachments: hive-209.patch, hive-junit-assert.patch
>
>
> We should enable assertions while running unit tests. Many assertions currently fail while running tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.