[GitHub] [incubator-superset] mistercrunch commented on pull request #10123: style: replace broken glyphs with font-awesome

[GitBox <gi...@apache.org>]

mistercrunch commented on pull request #10123:
URL: https://github.com/apache/incubator-superset/pull/10123#issuecomment-647270088


   @ktmud `SIP-34` provided icons as SVG, they're starting to land. Consistency would be great eventually. Between glyphicons, SIP-34 svg, react-icons, font-awesome, ... Maybe we need a `superset-ui-icons` package :)
   
   @etr2460 it'd be nice to be able to `grep` across all superset code. I `git grep` a lot and totally miss out on other repos. Also noticed that the documented `i18n` command currently doesn't inventorize the strings in `superset-ui*`, I spent a bit of time trying to fix this messing with `babel.cfg` (the python i18n babe-thing, not the JS one), with symlink, but nothing worked. Now I'm thinking git submodules OR a big mono-repo may work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org