You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Steve973 (via GitHub)" <gi...@apache.org> on 2023/03/25 16:47:57 UTC

[GitHub] [camel] Steve973 opened a new pull request, #9638: CAMEL-19198: Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property

Steve973 opened a new pull request, #9638:
URL: https://github.com/apache/camel/pull/9638

   CAMEL-19198: Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property
   
   # Description
   
   When filters are evaluated, the filters are now sorted by priority before being evaluated. 
   
   # Target
   
   - [x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [x ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   # Apache Camel coding standards and style
   
   - [x ] I checked that each commit in the pull request has a meaningful subject line and body.
   
   - [x ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #9638: CAMEL-19198: 3.x branch version -- Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9638:
URL: https://github.com/apache/camel/pull/9638#issuecomment-1483931185

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #9638: CAMEL-19198: Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9638:
URL: https://github.com/apache/camel/pull/9638#issuecomment-1483867732

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #9638: CAMEL-19198: 3.x branch version -- Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9638:
URL: https://github.com/apache/camel/pull/9638#issuecomment-1483922839

   backport this to 3.20.x and 3.18.x via cherry-pick 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] Steve973 commented on pull request #9638: CAMEL-19198: 3.x branch version -- Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property

Posted by "Steve973 (via GitHub)" <gi...@apache.org>.
Steve973 commented on PR #9638:
URL: https://github.com/apache/camel/pull/9638#issuecomment-1483938055

   @davsclaus I ran checkstyle on the entire code base, and it showed no violations.  And that was in addition to `mvn -Pformat,fastinstall install && mvn -Psourcecheck`.  Any idea why it failed?  The details didn't help me understand what went wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus merged pull request #9638: CAMEL-19198: 3.x branch version -- Added sorting logic to ensure dynamic router eip component filters are evaluated in order of their priority property

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9638:
URL: https://github.com/apache/camel/pull/9638


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org