You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/27 03:24:35 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
HuangXingBo opened a new pull request #11915:
URL: https://github.com/apache/flink/pull/11915
## What is the purpose of the change
*This pull request will Add the sign and sha logic for PyFlink wheel packages*
## Brief change log
- *Add the sign and sha logic for PyFlink wheel packages in create_binary_release.sh*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619691350
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dc1358b12a72c8fb87289083c585dd8345f41d86 (Mon Apr 27 03:27:16 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17395).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc1358b12a72c8fb87289083c585dd8345f41d86 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162143714) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162157240",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc1358b12a72c8fb87289083c585dd8345f41d86 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162143714) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278)
* c64af9f899aa267862f7aabcba240831c8e25cbc Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162157240) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288)
* 373433f64d0f4a601b38e276f132f7627565f550 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162157240",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc1358b12a72c8fb87289083c585dd8345f41d86 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162143714) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278)
* c64af9f899aa267862f7aabcba240831c8e25cbc Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162157240) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162157240",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162165389",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 373433f64d0f4a601b38e276f132f7627565f550 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162165389) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162157240",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162165389",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 373433f64d0f4a601b38e276f132f7627565f550 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162165389) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162157240",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162165389",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 373433f64d0f4a601b38e276f132f7627565f550 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162165389) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162157240",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162165389",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
}, {
"hash" : "373433f64d0f4a601b38e276f132f7627565f550",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293",
"triggerID" : "373433f64d0f4a601b38e276f132f7627565f550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c64af9f899aa267862f7aabcba240831c8e25cbc Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162157240) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=288)
* 373433f64d0f4a601b38e276f132f7627565f550 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162165389) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc1358b12a72c8fb87289083c585dd8345f41d86 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162143714) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11915:
URL: https://github.com/apache/flink/pull/11915#discussion_r415511471
##########
File path: tools/releasing/create_binary_release.sh
##########
@@ -109,14 +112,30 @@ make_python_release() {
cp ${pyflink_actual_name} "${RELEASE_DIR}/${pyflink_release_name}"
+ # RM need to move the downloaded wheel packages from Azure CI to the directory of flink-python/dist manually.
+ for wheel_file in *.whl; do
+ if [[ ! ${wheel_file} =~ ^apache_flink-$PYFLINK_VERSION- ]]; then
Review comment:
So the name of the wheel package is `apache_flink-version.whl` instead of `apache-flink-version.whl`?
##########
File path: tools/releasing/create_binary_release.sh
##########
@@ -94,7 +94,10 @@ make_python_release() {
cd flink-python/
# use lint-python.sh script to create a python environment.
dev/lint-python.sh -s basic
+ set +eu
Review comment:
Why we need this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc1358b12a72c8fb87289083c585dd8345f41d86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11915:
URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162143714",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278",
"triggerID" : "dc1358b12a72c8fb87289083c585dd8345f41d86",
"triggerType" : "PUSH"
}, {
"hash" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c64af9f899aa267862f7aabcba240831c8e25cbc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc1358b12a72c8fb87289083c585dd8345f41d86 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162143714) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=278)
* c64af9f899aa267862f7aabcba240831c8e25cbc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org