You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/28 17:36:30 UTC
[GitHub] [couchdb-nano] glynnbird opened a new pull request #210: stricter
TypeScript definitions with tsc --strict, fixes issue #209
glynnbird opened a new pull request #210: stricter TypeScript definitions with tsc --strict, fixes issue #209
URL: https://github.com/apache/couchdb-nano/pull/210
## Overview
Although the Typescript definitions were checked with `tsc`, folks using `tsc --strict` in their projects were seeing some errors. So I've enabled `tsc --strict` in package.json which shows up the errors, which are also fixed.
## Testing recommendations
TypeScript users with `--strict` compilation will see errors go away.
## GitHub issue number
Fixes issue #209
## Checklist
- [x] Code is written and works correctly;
- [x] Changes are covered by tests;
- [x] Documentation reflects the changes;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-nano] garrensmith commented on issue #210: stricter
TypeScript definitions with tsc --strict, fixes issue #209
Posted by GitBox <gi...@apache.org>.
garrensmith commented on issue #210: stricter TypeScript definitions with tsc --strict, fixes issue #209
URL: https://github.com/apache/couchdb-nano/pull/210#issuecomment-593077029
Nice fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-nano] glynnbird merged pull request #210: stricter
TypeScript definitions with tsc --strict, fixes issue #209
Posted by GitBox <gi...@apache.org>.
glynnbird merged pull request #210: stricter TypeScript definitions with tsc --strict, fixes issue #209
URL: https://github.com/apache/couchdb-nano/pull/210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services