You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2024/12/04 20:08:40 UTC
[PR] NIFI-14026 Add proxied-entity module for web-security and toolkit [nifi]
exceptionfactory opened a new pull request, #9567:
URL: https://github.com/apache/nifi/pull/9567
# Summary
[NIFI-14026](https://issues.apache.org/jira/browse/NIFI-14026) Adds the `nifi-security-proxied-entity` module under `nifi-commons` to provide a shared location for utilities related to Proxied Entities for HTTP requests and responses.
The `nifi-web-security` module has a `ProxiedEntitiesUtils` class that supports encoding and decoding, and the `nifi-toolkit-client` module had a dependency on `nifi-web-security` for encoding proxied entities. With the `nifi-web-security` module including many more dependencies than `nifi-toolkit-client` required, the `nifi-security-proxied-entity` module has a `StandardProxiedEntityEncoder` implementation to support the methods required in both places, without unnecessary dependencies.
Additional changes include removing the Google Guava dependency from `nifi-toolkit-cli`, which is no longer required following the removal of transitive framework dependencies from other toolkit modules.
The new Proxied Entity Encoder includes unit tests that exercise various cases supported in the original `ProxiedEntitiesUtils` class.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14026 Add proxied-entity module for web-security and toolkit [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #9567: NIFI-14026 Add proxied-entity module for web-security and toolkit
URL: https://github.com/apache/nifi/pull/9567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org