You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/01/30 23:35:35 UTC
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19461
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
IMPALA-11859: Add bytes-read-encrypted metric
Adds a metric bytes-read-encrypted to track encrypted reads.
Testing:
- ran test_io_metrics.py with Ozone (encrypts by default)
- ran test_io_metrics.py with HDFS (no encryption)
Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
---
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/orc/hdfs-orc-scanner.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/scheduling/scheduler.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/fbs/CatalogObjects.fbs
M common/protobuf/planner.proto
M common/thrift/PlanNodes.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
D fe/src/main/java/org/apache/impala/compat/HdfsShim.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/query_test/test_io_metrics.py
19 files changed, 79 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/19461/1
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12301/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Feb 2023 01:00:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9010/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 21:30:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 3: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 20:48:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9032/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Feb 2023 20:46:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 4: Code-Review+2
This looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Feb 2023 19:56:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12269/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 23:55:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19461
to look at the new patch set (#2).
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
IMPALA-11859: Add bytes-read-encrypted metric
Adds a metric bytes-read-encrypted to track encrypted reads.
Testing:
- ran test_io_metrics.py with Ozone (encrypts by default)
- ran test_io_metrics.py with HDFS (no encryption)
Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
---
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/orc/hdfs-orc-scanner.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/scheduling/scheduler.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/fbs/CatalogObjects.fbs
M common/protobuf/planner.proto
M common/thrift/PlanNodes.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
D fe/src/main/java/org/apache/impala/compat/HdfsShim.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/query_test/test_io_metrics.py
19 files changed, 79 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/19461/2
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
IMPALA-11859: Add bytes-read-encrypted metric
Adds a metric bytes-read-encrypted to track encrypted reads.
Testing:
- ran test_io_metrics.py with Ozone (encrypts by default)
- ran test_io_metrics.py with HDFS (no encryption)
Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Reviewed-on: http://gerrit.cloudera.org:8080/19461
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/orc/hdfs-orc-scanner.cc
M be/src/runtime/io/hdfs-file-reader.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/scheduling/scheduler.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/fbs/CatalogObjects.fbs
M common/protobuf/planner.proto
M common/thrift/PlanNodes.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
D fe/src/main/java/org/apache/impala/compat/HdfsShim.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/query_test/test_io_metrics.py
20 files changed, 76 insertions(+), 46 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 02:44:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Feb 2023 01:55:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12277/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 19:09:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19461
to look at the new patch set (#4).
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
IMPALA-11859: Add bytes-read-encrypted metric
Adds a metric bytes-read-encrypted to track encrypted reads.
Testing:
- ran test_io_metrics.py with Ozone (encrypts by default)
- ran test_io_metrics.py with HDFS (no encryption)
Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
---
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/orc/hdfs-orc-scanner.cc
M be/src/runtime/io/hdfs-file-reader.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/scheduling/scheduler.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/fbs/CatalogObjects.fbs
M common/protobuf/planner.proto
M common/thrift/PlanNodes.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
D fe/src/main/java/org/apache/impala/compat/HdfsShim.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/query_test/test_io_metrics.py
20 files changed, 76 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/19461/4
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 )
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12272/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 01:06:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19461
to look at the new patch set (#3).
Change subject: IMPALA-11859: Add bytes-read-encrypted metric
......................................................................
IMPALA-11859: Add bytes-read-encrypted metric
Adds a metric bytes-read-encrypted to track encrypted reads.
Testing:
- ran test_io_metrics.py with Ozone (encrypts by default)
- ran test_io_metrics.py with HDFS (no encryption)
Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
---
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/orc/hdfs-orc-scanner.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/scheduling/scheduler.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/fbs/CatalogObjects.fbs
M common/protobuf/planner.proto
M common/thrift/PlanNodes.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
D fe/src/main/java/org/apache/impala/compat/HdfsShim.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/query_test/test_io_metrics.py
19 files changed, 76 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/19461/3
--
To view, visit http://gerrit.cloudera.org:8080/19461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbc194a4bc31cb0e01545fb6032a0853db60f34
Gerrit-Change-Number: 19461
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>