You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/08 01:57:42 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10998: [Feature-10983] [refactor] ResourcesController

zhongjiajie commented on PR #10998:
URL: https://github.com/apache/dolphinscheduler/pull/10998#issuecomment-1207565161

   > It‘s better to create a new branch e.g. api-refactor, and don't merge this kind of pr to dev, otherwise, we may need to solve many conflicts before 4.0 @SbloodyS @caishunfeng @liguotian
   
   I find this patch almost adds new files and only changes the existing file `ResourcesController`, so it can be cherry-picked without not to many conflicts, So I think we can be merge into dev branch, I think I think the one need to create a new branch to keep code it significant change not compatible with the current code/function(maybe part of DSIP or foundation), and we didn't want to release it int the next released


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org