You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/05 03:15:34 UTC
[GitHub] [incubator-seatunnel] hailin0 opened a new pull request, #2644: [Bug] [Connector-v2-redis] Fix redis e2e-testcase connection reset
hailin0 opened a new pull request, #2644:
URL: https://github.com/apache/incubator-seatunnel/pull/2644
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Close #2643
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2644: [Bug] [Connector-v2-redis] Fix redis e2e-testcase connection reset
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2644:
URL: https://github.com/apache/incubator-seatunnel/pull/2644#issuecomment-1236503758
please help to review @TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2644: [Bug] [Connector-v2-redis] Fix redis e2e-testcase connection reset
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2644:
URL: https://github.com/apache/incubator-seatunnel/pull/2644#issuecomment-1236554960
> > please help to review @TyrantLucifer
>
> After reading the jedis-related source codes, the call stack of the connection method is as follows:
>
> jedis#set -> connection#executeCommand -> connection#sendCommand -> connection#connect
>
> So I think add these codes is useless.
>
> Redis e2e test cases has no problem in my local environment and github action environment, it's may be a problem with your local environment configuration.
This depends on the performance of the operating environment.
This function waiting for redis server start completed and connected to redis server successful. This requires calling Jedis#connect to guarantee.
```java
given().ignoreExceptions()
.await()
.atMost(180, TimeUnit.SECONDS)
.untilAsserted(this::initJedis);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #2644: [Bug] [Connector-v2-redis] Fix redis e2e-testcase connection reset
Posted by GitBox <gi...@apache.org>.
TyrantLucifer merged PR #2644:
URL: https://github.com/apache/incubator-seatunnel/pull/2644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2644: [Bug] [Connector-v2-redis] Fix redis e2e-testcase connection reset
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2644:
URL: https://github.com/apache/incubator-seatunnel/pull/2644#issuecomment-1236520295
> please help to review @TyrantLucifer
After reading the jedis-related source codes, the call stack of the connection method is as follows:
jedis#set -> connection#executeCommand -> connection#sendCommand -> connection#connect
So I think add these codes is useless.
Redis e2e test cases has no problem in my local environment and github action environment, it's may be a problem with your local environment configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org