You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Daniel Kulp (JIRA)" <ji...@codehaus.org> on 2007/11/06 22:31:35 UTC
[jira] Created: (MSOURCES-27) source jar includes .svn directories
source jar includes .svn directories
------------------------------------
Key: MSOURCES-27
URL: http://jira.codehaus.org/browse/MSOURCES-27
Project: Maven 2.x Source Plugin
Issue Type: Bug
Affects Versions: 2.0.3
Reporter: Daniel Kulp
Fix For: 2.0.3
source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-27) source jar includes .svn
directories
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112996 ]
Dennis Lundberg commented on MSOURCES-27:
-----------------------------------------
I have checked the source code and it used the default excludes from org.codehaus.plexus.util.DirectoryScanner, which excludes "**/.svn" and "**/.svn/**" among other things.
I also tried this on the trunk of commons-logging using maven-source-plugin 2.0.3 and 2.0.4-SNAPSHOT and none of them include any .svn directories.
Do you have a publicly available test case that isn't working for you?
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-27) source jar includes .svn
directories
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113005 ]
Dennis Lundberg commented on MSOURCES-27:
-----------------------------------------
Do you expect the <exclude> to mean: "use the default excludes and add this one"? And that was the behavior in maven-sources-plugin 2.0.2?
Just out of curiosity, is there a reason for not having the properties files in /src/main/resources/... ?
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-27) source jar includes .svn
directories
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113017 ]
Daniel Kulp commented on MSOURCES-27:
-------------------------------------
Yep. That looks right to me. That matches 2.0.2 as well as the behavior of the resource plugin.
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-27) source jar includes .svn
directories
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113004 ]
Daniel Kulp commented on MSOURCES-27:
-------------------------------------
Just checked the resource plugin. The resource plugin does:
{code}
if ( resource.getExcludes() != null && !resource.getExcludes().isEmpty() )
{
scanner.setExcludes( (String[]) resource.getExcludes().toArray( EMPTY_STRING_ARRAY ) );
}
scanner.addDefaultExcludes();
scanner.scan();
{code}
Thus, it always adds the default excludes to the scanner that it uses. The sources plugin should follow the same behavior to make sure the two are consistent.
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-27) source jar includes .svn
directories
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113010 ]
Dennis Lundberg commented on MSOURCES-27:
-----------------------------------------
I can now confirm that 2.0.2 works as describe in my previous comment.
I'm considering changing from
{code}
if ( resourceExcludes == null || resourceExcludes.size() == 0 )
{
excludes = FileUtils.getDefaultExcludes();
}
else
{
excludes = (String[]) resourceExcludes.toArray( new String[resourceExcludes.size()] );
}
{code}
to
{code}
if ( resourceExcludes == null || resourceExcludes.size() == 0 )
{
excludes = FileUtils.getDefaultExcludes();
}
else
{
List allExcludes = new ArrayList();
allExcludes.addAll( FileUtils.getDefaultExcludesAsList() );
allExcludes.addAll( resourceExcludes );
excludes = (String[]) allExcludes.toArray( new String[allExcludes.size()] );
}
{code}
Does that sound right to you Daniel?
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-27) source jar includes .svn
directories
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113000 ]
Daniel Kulp commented on MSOURCES-27:
-------------------------------------
This one is a bit more complex. For CXF, we have properties files in the src/main/java dir (i18n message files) that are included via resource. Thus, in the pom, we have:
<resources>
<resource>
<directory>src/main/java</directory>
<excludes>
<exclude>**/*.java</exclude>
</excludes>
</resource>
</resources>
to grab all the non-java files as resources.
The new source plugin uses the **/*.java as an exclude, but but DOESN'T add the list of default excludes. Thus, the source plugin will get the .svn dirs.
Basically, for resources that don't have excludes, the source plugin works fine as it uses the default excludes. For those that DO define an exclude, it doesn't quite work as expected.
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSOURCES-27) Specifying excludes in the
configuration removes the default excludes
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MSOURCES-27.
-----------------------------------
Assignee: Dennis Lundberg
Resolution: Fixed
Fix Version/s: 2.0.4
Fixed in r592826.
> Specifying excludes in the configuration removes the default excludes
> ---------------------------------------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
> Assignee: Dennis Lundberg
> Fix For: 2.0.4
>
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-27) source jar includes .svn
directories
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112994 ]
Daniel Kulp commented on MSOURCES-27:
-------------------------------------
Note: it's only grabbing the SVN directories for SOURCE directories, not resource directories.
The default excludes seem to be OK for resources.
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
> Fix For: 2.0.3
>
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSOURCES-27) source jar includes .svn directories
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MSOURCES-27:
------------------------------------
Description:
source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
was:
source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
Fix Version/s: (was: 2.0.3)
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MSOURCES-27) source jar includes .svn
directories
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112996 ]
Dennis Lundberg edited comment on MSOURCES-27 at 11/6/07 5:15 PM:
------------------------------------------------------------------
I have checked the source code and it used the default excludes from org.codehaus.plexus.util.DirectoryScanner, which excludes "\*\*/.svn" and "\*\*/.svn/\*\*" among other things.
I also tried this on the trunk of commons-logging using maven-source-plugin 2.0.3 and 2.0.4-SNAPSHOT and none of them include any .svn directories.
Do you have a publicly available test case that isn't working for you?
was:
I have checked the source code and it used the default excludes from org.codehaus.plexus.util.DirectoryScanner, which excludes "**/.svn" and "**/.svn/**" among other things.
I also tried this on the trunk of commons-logging using maven-source-plugin 2.0.3 and 2.0.4-SNAPSHOT and none of them include any .svn directories.
Do you have a publicly available test case that isn't working for you?
> source jar includes .svn directories
> ------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSOURCES-27) Specifying excludes in the
configuration removes the default excludes
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MSOURCES-27:
------------------------------------
Summary: Specifying excludes in the configuration removes the default excludes (was: source jar includes .svn directories)
> Specifying excludes in the configuration removes the default excludes
> ---------------------------------------------------------------------
>
> Key: MSOURCES-27
> URL: http://jira.codehaus.org/browse/MSOURCES-27
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
>
> source:jar with 2.0.3 is adding the .svn directories into the jar. 2.0.2 did not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira