You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "haohuaijin (via GitHub)" <gi...@apache.org> on 2026/09/22 14:22:56 UTC
[PR] refactor: use row-group-local selections for Parquet scans [datafusion]
haohuaijin opened a new pull request, #25608:
URL: https://github.com/apache/datafusion/pull/25608
## Which issue does this PR close?
Related to #24358. This is a preparatory refactor and does not close that issue.
## Rationale for this change
Parquet access plans already describe selections per row group, but the scan path flattens them into one selection and reconstructs group boundaries when reversing the scan. Keeping selections attached to their row groups preserves local coordinates and bitmap representations while simplifying ordering and decoder rebuilds.
## What changes are included in this PR?
- Pass row-group-local selections to the Parquet push decoder and keep each selection together with its static match status.
- Validate selection lengths and remove empty selections during preparation; reverse and reorder whole row-group entries.
- Remove flat-selection assembly and reversal helpers, and consolidate the reversal tests.
- Reuse the decoder's remaining selections when only the row filter changes, avoiding redundant selector copies.
- Preserve the current policy that disables statistics reordering and runtime pruning for scans with selections.
## What is the testing strategy for this PR?
The new integration test covers mixed bitmap and selector selections across row groups. Unit tests cover selection validation, empty selections, match-status alignment, and reversal of non-contiguous groups with unequal sizes.
Passed targeted tests:
- `cargo test -p datafusion-datasource-parquet --lib access_plan::test --offline`
- `cargo test -p datafusion-datasource-parquet --lib sort::tests --offline`
- `cargo test -p datafusion-datasource-parquet --lib push_decoder::tests --offline`
- `cargo test -p datafusion-datasource-parquet --lib statistics_order_tests --offline`
- `cargo test -p datafusion --test parquet_integration external_access_plan --offline`
- `cargo test -p datafusion --test parquet_integration dynamic_row_group_pruning --offline`
Pre-submission checks: `cargo fmt --all`, `cargo clippy --all-targets --all-features -- -D warnings`, and `uv run ./dev/rust_lint.sh`.
## Are there any user-facing changes?
Breaking Rust API change: removes `ParquetAccessPlan::into_overall_row_selection` without adding a replacement public conversion API. The 56.0.0 upgrade guide describes migration for direct callers. Users who attach a `ParquetAccessPlan` to a `PartitionedFile` for DataFusion to scan do not need changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on code in PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#discussion_r4081980300
##########
datafusion/datasource-parquet/src/sort.rs:
##########
@@ -18,109 +18,10 @@
//! Sort-related utilities for Parquet scanning
use arrow::datatypes::Schema;
-use datafusion_common::{Result, ScalarValue};
+use datafusion_common::ScalarValue;
use datafusion_datasource::PartitionedFile;
use datafusion_physical_expr::expressions::Column;
use datafusion_physical_expr_common::sort_expr::LexOrdering;
-use parquet::arrow::arrow_reader::{RowSelection, RowSelector};
-use parquet::file::metadata::ParquetMetaData;
-use std::collections::HashMap;
-
-/// Reverse a row selection to match reversed row group order.
Review Comment:
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5793916094
😍
<img width="288" height="75" alt="Screenshot 2026-09-23 at 7 21 44 AM" src="https://github.com/user-attachments/assets/694ef590-01af-4c5c-8d1d-6f62ddc11ea2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#discussion_r4081895313
##########
datafusion/datasource-parquet/src/sort.rs:
##########
@@ -18,109 +18,10 @@
//! Sort-related utilities for Parquet scanning
use arrow::datatypes::Schema;
-use datafusion_common::{Result, ScalarValue};
+use datafusion_common::ScalarValue;
use datafusion_datasource::PartitionedFile;
use datafusion_physical_expr::expressions::Column;
use datafusion_physical_expr_common::sort_expr::LexOrdering;
-use parquet::arrow::arrow_reader::{RowSelection, RowSelector};
-use parquet::file::metadata::ParquetMetaData;
-use std::collections::HashMap;
-
-/// Reverse a row selection to match reversed row group order.
Review Comment:
the idea here is we don't need to reverse selection anymore because the selections are already done per-row group and thus they don't need to be resplit, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5779520756
Hi @zhuqi-lucas @alamb, please help reviews, this pr integrates `with_row_group_selections` into parquet scans, removing the conversion to a global row selection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5788669156
Thanks @sunchao @zhuqi-lucas for reviews, i added the suggestion comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5780697857
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion v55.1.0 (current)
Built [ 72.544s] (current)
Parsing datafusion v55.1.0 (current)
Parsed [ 0.036s] (current)
Building datafusion v55.1.0 (baseline)
Built [ 64.166s] (baseline)
Parsing datafusion v55.1.0 (baseline)
Parsed [ 0.036s] (baseline)
Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch)
Checked [ 0.634s] 223 checks: 223 pass, 31 skip
Summary no semver update required
Finished [ 139.322s] datafusion
Building datafusion-datasource-parquet v55.1.0 (current)
Built [ 55.165s] (current)
Parsing datafusion-datasource-parquet v55.1.0 (current)
Parsed [ 0.036s] (current)
Building datafusion-datasource-parquet v55.1.0 (baseline)
Built [ 54.548s] (baseline)
Parsing datafusion-datasource-parquet v55.1.0 (baseline)
Parsed [ 0.037s] (baseline)
Checking datafusion-datasource-parquet v55.1.0 -> v55.1.0 (no change; assume patch)
Checked [ 0.150s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron
Failed in:
ParquetAccessPlan::into_overall_row_selection, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/datasource-parquet/src/access_plan.rs:470
ParquetAccessPlan::into_overall_row_selection, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d942a43a7cb81984f010ff2d9cd45b075514c904/datafusion/datasource-parquet/src/access_plan.rs:470
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 111.437s] datafusion-datasource-parquet
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #25608:
URL: https://github.com/apache/datafusion/pull/25608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#discussion_r4078504623
##########
datafusion/datasource-parquet/src/access_plan.rs:
##########
@@ -565,137 +576,83 @@ impl ParquetAccessPlan {
self.row_groups
}
- /// Prepare this plan and resolve to the final `PreparedAccessPlan`
+ /// Validate selections and prepare row groups for the decoder without
+ /// converting local selections into a single file-level selection.
pub(crate) fn prepare(
- mut self,
+ self,
row_group_meta_data: &[RowGroupMetaData],
) -> Result<PreparedAccessPlan> {
- let row_group_indexes = self.row_group_indexes();
- // `fully_matched` is indexed by absolute row-group index; take it out
- // before `into_overall_row_selection` consumes `self`.
- let fully_matched_by_index = std::mem::take(&mut self.fully_matched);
- let row_selection = self.into_overall_row_selection(row_group_meta_data)?;
-
- let (row_group_indexes, row_selection) =
- strip_empty_row_groups(row_group_indexes, row_selection, row_group_meta_data);
-
- // Carry `fully_matched` flags in the same order as the *surviving*
- // `row_group_indexes` so downstream code (per-RG `RowFilter` skip) can
- // look them up positionally. Mapping after the strip keeps
- // `strip_empty_row_groups` generic (no `fully_matched` parameter).
- let fully_matched: Vec<bool> = row_group_indexes
+ assert_eq!(row_group_meta_data.len(), self.row_groups.len());
+ // Keep the scan policies that previously depended on the presence of
+ // an overall selection, even when its partial groups are all empty.
+ let has_row_selection = self
Review Comment:
This restriction gets more interesting after this PR. Statistics reordering and runtime pruning were disabled in the presence of a selection because the coordinates were global — dropping a row group at runtime invalidated every offset after it in the flat selection. With row-group-local selections that reason is gone: a dropped group takes its own selection with it and nothing else shifts.
Lifting it is probably what actually closes #24358. Worth a follow-up issue if you're not planning to do it here.
##########
datafusion/datasource-parquet/src/access_plan.rs:
##########
@@ -565,137 +576,83 @@ impl ParquetAccessPlan {
self.row_groups
}
- /// Prepare this plan and resolve to the final `PreparedAccessPlan`
+ /// Validate selections and prepare row groups for the decoder without
+ /// converting local selections into a single file-level selection.
pub(crate) fn prepare(
- mut self,
+ self,
row_group_meta_data: &[RowGroupMetaData],
) -> Result<PreparedAccessPlan> {
- let row_group_indexes = self.row_group_indexes();
- // `fully_matched` is indexed by absolute row-group index; take it out
- // before `into_overall_row_selection` consumes `self`.
- let fully_matched_by_index = std::mem::take(&mut self.fully_matched);
- let row_selection = self.into_overall_row_selection(row_group_meta_data)?;
-
- let (row_group_indexes, row_selection) =
- strip_empty_row_groups(row_group_indexes, row_selection, row_group_meta_data);
-
- // Carry `fully_matched` flags in the same order as the *surviving*
- // `row_group_indexes` so downstream code (per-RG `RowFilter` skip) can
- // look them up positionally. Mapping after the strip keeps
- // `strip_empty_row_groups` generic (no `fully_matched` parameter).
- let fully_matched: Vec<bool> = row_group_indexes
+ assert_eq!(row_group_meta_data.len(), self.row_groups.len());
+ // Keep the scan policies that previously depended on the presence of
+ // an overall selection, even when its partial groups are all empty.
+ let has_row_selection = self
+ .row_groups
.iter()
- .map(|&idx| fully_matched_by_index[idx])
- .collect();
-
- PreparedAccessPlan::new(row_group_indexes, fully_matched, row_selection)
- }
-}
-
-/// Drop row groups whose post-pruning `RowSelection` selects zero rows, so the
-/// prepared plan stays well-formed: `with_row_groups(...)` never names a row
-/// group the decoder would immediately skip.
-///
-/// arrow-rs's push decoder silently advances past an all-skipped row group
-/// inside `try_next_reader` without handing back a reader, so keeping such a
-/// row group in the plan would leave its row-group list one entry longer than
-/// the readers the decoder produces. An empty selection is reachable today via
-/// [`ParquetAccessPlan::scan_selection`], which intersects an existing
-/// `Selection` with a new one and can leave a row group selecting nothing.
-/// A well-formed plan here is also a precondition for re-enabling runtime
-/// pruning under a live selection (#24358) and for #23696.
-///
-/// Walks the flat `RowSelection` once with [`OverallRowSelectionCursor`],
-/// rather than a per-row-group [`RowSelection::split_off`] (which reallocates
-/// the selector tail on every call, i.e. O(row groups × selectors)), keeping
-/// only the row groups that still select at least one row. `row_group_meta_data`
-/// is the **full file** metadata, indexed absolutely by row-group index, while
-/// `row_selection` covers only the scanned row groups — matching
-/// `into_overall_row_selection`, which emits nothing for a skipped row group.
-/// When `row_selection` is `None` no row group can be empty and the inputs are
-/// returned unchanged.
-fn strip_empty_row_groups(
- row_group_indexes: Vec<usize>,
- row_selection: Option<RowSelection>,
- row_group_meta_data: &[RowGroupMetaData],
-) -> (Vec<usize>, Option<RowSelection>) {
- let Some(selection) = row_selection else {
- return (row_group_indexes, None);
- };
-
- let mut cursor = OverallRowSelectionCursor::new(selection);
- let mut kept_indexes = Vec::with_capacity(row_group_indexes.len());
- let mut kept_selectors: Vec<RowSelector> = Vec::new();
-
- for &rg_idx in row_group_indexes.iter() {
- let rg_row_count = row_group_meta_data[rg_idx].num_rows() as usize;
- // Pull this row group's fragments off the shared cursor in a single
- // pass (no `split_off` tail reallocation).
- let start = kept_selectors.len();
- let mut selected = 0usize;
- let mut taken = 0usize;
- while taken < rg_row_count {
- let Some(fragment) = cursor.take(rg_row_count - taken) else {
- break;
+ .any(|access| matches!(access, RowGroupAccess::Selection(_)));
+ let mut row_groups = Vec::with_capacity(self.row_groups.len());
+ for (index, (access, fully_matched)) in self
+ .row_groups
+ .into_iter()
+ .zip(self.fully_matched)
+ .enumerate()
+ {
+ let selection = match access {
+ RowGroupAccess::Skip => continue,
+ RowGroupAccess::Scan => {
+ if has_row_selection && row_group_meta_data[index].num_rows() == 0 {
Review Comment:
Why is the zero-row skip gated on `has_row_selection`? An empty row group contributes nothing either way, so the asymmetry looks like it's preserving some exact prior behaviour — a short comment naming which one would help the next reader.
##########
datafusion/datasource-parquet/src/push_decoder.rs:
##########
@@ -100,10 +101,7 @@ impl DecoderBuilderConfig<'_> {
if self.force_filter_selections {
builder = builder.with_row_selection_policy(RowSelectionPolicy::Selectors);
}
- if let Some(row_selection) = prepared_access_plan.row_selection {
- builder = builder.with_row_selection(row_selection);
- }
- builder = builder.with_row_groups(prepared_access_plan.row_group_indexes);
+ builder = builder.with_row_group_selections(row_group_selections);
Review Comment:
Might be worth spelling out in the description which drift this closes and which it doesn't. `sync_rg_plan_to_decoder_frontier` further down is for a different one — arrow-rs finishes a row group whose post-predicate selection is empty without handing back a reader, so `rg_plan` trails the decoder by one (#24352). That's untouched here and that seems right, but #24358 reads like it covers both, so it would be easy to over-read this as closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5820684988
<img width="159" height="35" alt="Screenshot 2026-09-24 at 2 21 44 PM" src="https://github.com/user-attachments/assets/d13d6206-20a9-450b-9b3b-e34c6cfa02da" />
AMazing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5781614437
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25608?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `99.40299%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 82.41%. Comparing base ([`6574a8c`](https://app.codecov.io/gh/apache/datafusion/commit/6574a8c3b2c93ef9689a677c1cc1c0a4a844617f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e6d6da2`](https://app.codecov.io/gh/apache/datafusion/commit/e6d6da280fa5797954dcfa006da90d93d1e3222e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 12 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/25608?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [datafusion/datasource-parquet/src/access\_plan.rs](https://app.codecov.io/gh/apache/datafusion/pull/25608?src=pr&el=tree&filepath=datafusion%2Fdatasource-parquet%2Fsrc%2Faccess_plan.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9kYXRhc291cmNlLXBhcnF1ZXQvc3JjL2FjY2Vzc19wbGFuLnJz) | 99.50% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/datasource-parquet/src/sort.rs](https://app.codecov.io/gh/apache/datafusion/pull/25608?src=pr&el=tree&filepath=datafusion%2Fdatasource-parquet%2Fsrc%2Fsort.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9kYXRhc291cmNlLXBhcnF1ZXQvc3JjL3NvcnQucnM=) | 99.07% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25608 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.02%
==========================================
Files 1138 1140 +2
Lines 435501 435145 -356
Branches 435501 435145 -356
==========================================
- Hits 358955 358605 -350
+ Misses 54841 54822 -19
- Partials 21705 21718 +13
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25608?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5795079028
I'll take a look, the diff looks great 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: use row-group-local selections for Parquet scans [datafusion]
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on PR #25608:
URL: https://github.com/apache/datafusion/pull/25608#issuecomment-5825055256
Thanks all for the reviews and support!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org