[jira] [Commented] (GUACAMOLE-482) Possible unreachable code in guacenc

["Michael Jumper (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324560#comment-16324560 ] 

Michael Jumper commented on GUACAMOLE-482:
------------------------------------------

{quote}
... the function called "guacenc_video_advance_timeline" doesn't appear to have a path that can return 1. 
{quote}

While that may well be true, the documented behavior of the functions invoked here define that non-zero return values will be used in the event of an error. The fact that the function in practice does not currently fail does not remove the need to handle the defined potential for failure, nor for the function to define that potential failure at least at an API level.

{quote}
Reporting because I wasn't sure if this was an artifact from a refactor, a bug where guacenc_video_advance_timeline should have a path that returns 1, or if it was just a bit of extra code that can go away.
{quote}

It may be that {{guacenc_video_advance_timeline()}} should be handling the potential error from {{guacenc_video_flush_frame()}}:


> Possible unreachable code in guacenc
> ------------------------------------
>
>                 Key: GUACAMOLE-482
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-482
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacenc
>    Affects Versions: 0.9.13-incubating
>         Environment: using provided dockerfile build 
>            Reporter: Ryan Underwood
>            Priority: Trivial
>
> In this file: https://github.com/apache/guacamole-server/blob/master/src/guacenc/display-sync.c line 52, the function called "guacenc_video_advance_timeline" doesn't appear to have a path that can return 1. 
> Reporting because  I wasn't sure if this was an artifact from a refactor, a bug where guacenc_video_advance_timeline _should_ have a path that returns 1, or if it was just a bit of extra code that can go away. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)