You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/10 16:57:15 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10762:
[FLINK-15115][kafka] Drop Kafka 0.8/0.9
tillrohrmann commented on a change in pull request #10762: [FLINK-15115][kafka] Drop Kafka 0.8/0.9
URL: https://github.com/apache/flink/pull/10762#discussion_r365328481
##########
File path: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer010.java
##########
@@ -173,7 +205,38 @@ public FlinkKafkaConsumer010(Pattern subscriptionPattern, DeserializationSchema<
*/
@PublicEvolving
public FlinkKafkaConsumer010(Pattern subscriptionPattern, KafkaDeserializationSchema<T> deserializer, Properties props) {
- super(subscriptionPattern, deserializer, props);
+ this(null, subscriptionPattern, deserializer, props);
Review comment:
Can we avoid `null` and instead pass in an empty collection? If not, then let's add `@Nullable` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services