[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4472: Use hit counter to track max QPS per minute for broker

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4472: Use hit counter to track max QPS per minute for broker
URL: https://github.com/apache/incubator-pinot/pull/4472#discussion_r307974402
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HitCounter.java
 ##########
 @@ -22,23 +22,36 @@
 import java.util.concurrent.atomic.AtomicIntegerArray;
 import java.util.concurrent.atomic.AtomicLongArray;
 
-
 /**
- * This hit counter is for counting the number of hits within a range of time. Right now the granularity we use is second.
- * In order to save the space and time, we store the number of hits over the last 100 time buckets. When the method hit
- * gets called, we put the timestamp to the specified bucket. When the method getHitCount gets called, we sum all the number
- * of hits within the last 100 time buckets.
+ * This hit counter is for counting the number of hits within a range of time.
+ * Right now the granularity we use is configured the users. Currently two users
 
 Review comment:
   "configured by the users"? I think we can omit this, since the ctor kind of indicates that the granularity is used by whoever calls the constructor. The use of the term "user" here could somehow indicate the user of pinot, or administrator of pinot -- neither of which is true in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org