You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2016/09/23 20:56:30 UTC
[1/2] incubator-impala git commit: IMPALA-4011: Remove / reword
messages when statestore messages are late
Repository: incubator-impala
Updated Branches:
refs/heads/master 0d0c93ec8 -> d83783e24
IMPALA-4011: Remove / reword messages when statestore messages are late
Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc
Reviewed-on: http://gerrit.cloudera.org:8080/4500
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Internal Jenkins
Reviewed-by: Juan Yu <jy...@cloudera.com>
Reviewed-by: Henry Robinson <he...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/2465539d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/2465539d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/2465539d
Branch: refs/heads/master
Commit: 2465539dc15ffe51a8b424dad6aee65fa1a72d98
Parents: 0d0c93e
Author: Henry Robinson <he...@cloudera.com>
Authored: Wed Sep 21 15:22:21 2016 -0700
Committer: Henry Robinson <he...@cloudera.com>
Committed: Fri Sep 23 05:57:44 2016 +0000
----------------------------------------------------------------------
be/src/statestore/statestore.cc | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/2465539d/be/src/statestore/statestore.cc
----------------------------------------------------------------------
diff --git a/be/src/statestore/statestore.cc b/be/src/statestore/statestore.cc
index e325292..5ef7cac 100644
--- a/be/src/statestore/statestore.cc
+++ b/be/src/statestore/statestore.cc
@@ -626,21 +626,19 @@ void Statestore::DoSubscriberUpdate(bool is_heartbeat, int thread_id,
VLOG(3) << "Sending " << hb_type << " message to: " << update.second
<< " (deadline accuracy: " << diff_ms << "ms)";
- if (diff_ms > DEADLINE_MISS_THRESHOLD_MS) {
- // TODO: This should be a healthcheck in a monitored metric in CM, which would
- // require a 'rate' metric type.
- const string& msg = Substitute("Missed subscriber ($0) $1 deadline by $2ms, "
- "consider increasing --$3 (currently $4)", update.second, hb_type, diff_ms,
- is_heartbeat ? "statestore_heartbeat_frequency_ms" :
- "statestore_update_frequency_ms",
- is_heartbeat ? FLAGS_statestore_heartbeat_frequency_ms :
- FLAGS_statestore_update_frequency_ms);
- if (is_heartbeat) {
- LOG(WARNING) << msg;
- } else {
- VLOG_QUERY << msg;
- }
+ if (diff_ms > DEADLINE_MISS_THRESHOLD_MS && is_heartbeat) {
+ const string& msg = Substitute(
+ "Missed subscriber ($0) $1 deadline by $2ms, "
+ "consider increasing --statestore_heartbeat_frequency_ms (currently $3) on "
+ "this Statestore, and --statestore_subscriber_timeout_seconds "
+ "on subscribers (Impala daemons and the Catalog Server)",
+ update.second, hb_type, diff_ms, FLAGS_statestore_heartbeat_frequency_ms);
+ LOG(WARNING) << msg;
}
+ // Don't warn for topic updates - they can be slow and still correct. Recommending an
+ // increase in update period will just confuse (as will increasing the thread pool
+ // size) because it's hard for users to pick a good value, they may still see these
+ // messages and it won't be a correctness problem.
} else {
// The first update is scheduled immediately and has a deadline of 0. There's no need
// to wait.
[2/2] incubator-impala git commit: IMPALA-4194: Bump version to 2.8.0
Posted by ta...@apache.org.
IMPALA-4194: Bump version to 2.8.0
Change-Id: I57a3655bf72d53bd7dd273d5d73de05d8ff332ab
Reviewed-on: http://gerrit.cloudera.org:8080/4525
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/d83783e2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/d83783e2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/d83783e2
Branch: refs/heads/master
Commit: d83783e2464a50b04cec7a3df774306af5a62cdd
Parents: 2465539
Author: Lars Volker <lv...@cloudera.com>
Authored: Fri Sep 23 09:08:06 2016 -0700
Committer: Internal Jenkins <cl...@gerrit.cloudera.org>
Committed: Fri Sep 23 20:33:24 2016 +0000
----------------------------------------------------------------------
bin/save-version.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/d83783e2/bin/save-version.sh
----------------------------------------------------------------------
diff --git a/bin/save-version.sh b/bin/save-version.sh
index bc0de75..64f4221 100755
--- a/bin/save-version.sh
+++ b/bin/save-version.sh
@@ -21,7 +21,7 @@
# Note: for internal (aka pre-release) versions, the version should have
# "-INTERNAL" appended. Parts of the code will look for this to distinguish
# between released and internal versions.
-VERSION=2.7.0
+VERSION=2.8.0
GIT_HASH=$(git rev-parse HEAD 2> /dev/null)
if [ -z $GIT_HASH ]
then