You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/09/20 23:56:49 UTC
[GitHub] [myfaces] pnicolucci opened a new pull request, #316: MYFACES-4460: remove JSTL(Tags) dependency
pnicolucci opened a new pull request, #316:
URL: https://github.com/apache/myfaces/pull/316
https://issues.apache.org/jira/browse/MYFACES-4460
Also removing the import for `javax.servlet.jsp`, `javax.servlet.jsp.tagext`, and `javax.servlet.jsp.jstl.core`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #316:
URL: https://github.com/apache/myfaces/pull/316#issuecomment-1253607171
I defer to @tandraschko on the TLD question :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #316:
URL: https://github.com/apache/myfaces/pull/316#issuecomment-1253124405
@melloware @tandraschko I see we still have some tld files as well in the code base. Any argument against me removing those as part of this PR as well? If not I'll work on that tomorrow and ask for another set of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #316:
URL: https://github.com/apache/myfaces/pull/316#issuecomment-1253666208
As a note it does look like these were removed in Mojarra during the "JSP removal": https://github.com/eclipse-ee4j/mojarra/commit/96757f39d47bf05060103b67933eb6afe9fd9278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #316:
URL: https://github.com/apache/myfaces/pull/316#issuecomment-1255881953
TLD was JSP only, right? so just kick it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko merged pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
tandraschko merged PR #316:
URL: https://github.com/apache/myfaces/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #316:
URL: https://github.com/apache/myfaces/pull/316#issuecomment-1253170952
I think we can remove the following from the `impl/pom.xml`:
> <execution>
> <id>makecoretld</id>
> <configuration>
> <xmlFile>META-INF/myfaces_core.tld</xmlFile>
> <templateFile>myfaces_core12.vm</templateFile>
> <modelIds>
> <modelId>myfaces-api</modelId>
> <modelId>myfaces-impl</modelId>
> </modelIds>
> <params>
> <shortname>f</shortname>
> <uri>http://java.sun.com/jsf/core</uri>
> <displayname>JSF core tag library.</displayname>
> <description>This tag library implements the standard JSF core tags.</description>
> </params>
> </configuration>
> <goals>
> <goal>make-config</goal>
> </goals>
> </execution>
>
> <execution>
> <id>makehtmltld</id>
> <configuration>
> <xmlFile>META-INF/myfaces_html.tld</xmlFile>
> <xmlBaseFile>src/main/conf/META-INF/myfaces_html-base.tld</xmlBaseFile>
> <templateFile>myfaces_html12.vm</templateFile>
> <params>
> <shortname>h</shortname>
> <uri>http://java.sun.com/jsf/html</uri>
> <displayname>JSF HTML tag library.</displayname>
> <description>This tag library implements the standard JSF HTML tags.</description>
> </params>
> <modelIds>
> <modelId>myfaces-api</modelId>
> </modelIds>
> </configuration>
> <goals>
> <goal>make-config</goal>
> </goals>
> </execution>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #316:
URL: https://github.com/apache/myfaces/pull/316#issuecomment-1253034128
Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #316: MYFACES-4460: remove JSTL(Tags) dependency
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #316:
URL: https://github.com/apache/myfaces/pull/316#issuecomment-1253175438
pushed the changes mentioned above into this PR. Let me know if you have any questions or concerns. My builds locally look good with all the tests passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org