You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/12 01:19:46 UTC
[GitHub] [solr] madrob opened a new pull request #260: SOLR-15583 Update error-prone to 2.8.1
madrob opened a new pull request #260:
URL: https://github.com/apache/solr/pull/260
https://issues.apache.org/jira/browse/SOLR-15583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #260: SOLR-15583 Update error-prone to 2.8.1
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #260:
URL: https://github.com/apache/solr/pull/260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #260: SOLR-15583 Update error-prone to 2.8.1
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #260:
URL: https://github.com/apache/solr/pull/260#discussion_r688010778
##########
File path: solr/core/src/java/org/apache/solr/pkg/PackageLoader.java
##########
@@ -360,6 +360,7 @@ public InputStream openResource(String resource) {
}
}
+ @SuppressWarnings("CompareToZero") // TODO either document why or fix this
Review comment:
@noblepaul do you recall why you did `v.compareTo(lessThan) < 1` down below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org