[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #253: PIP-254: Support configuring client version with a description suffix

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower commented on code in PR #253:
URL: https://github.com/apache/pulsar-client-cpp/pull/253#discussion_r1169410259


##########
lib/ConnectionPool.h:
##########
@@ -41,7 +41,8 @@ using ExecutorServiceProviderPtr = std::shared_ptr<ExecutorServiceProvider>;
 class PULSAR_PUBLIC ConnectionPool {
    public:
     ConnectionPool(const ClientConfiguration& conf, ExecutorServiceProviderPtr executorProvider,
-                   const AuthenticationPtr& authentication, bool poolConnections = true);
+                   const AuthenticationPtr& authentication, bool poolConnections,

Review Comment:
   Because I added a parameter `clientVersion` at the tail. The default parameter not at the tail is meaningless.
   
   Additional, in C++, a default parameter works by generating one more function symbol, it's better not to add a default value just for tests. In the `lib/` subdirectory, the constructor of `ConnectionPool` is only called in `ClientImpl`'s constructor, so we only need one constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org