[GitHub] [flink] alpreu commented on pull request #19085: [FLINK-26638][connectors/elasticsearch] Add user-definable ActionFailureHandler to unified Elasticsearch Sink

[GitBox <gi...@apache.org>]

alpreu commented on pull request #19085:
URL: https://github.com/apache/flink/pull/19085#issuecomment-1066886794


   One thing I really don't like is that when we ported the Sink to the unified interface, we created a new `RequestIndexer` class in the `connector.elasticsearch` package. The old RequestIndexer remained in the `streaming.connectors.elasticsearch` package. Now, when reintroducing the `ActionFailureHandler` we would need to duplicate this interface (as well as the implementations we provide) as well if we wat to deprecate the old one. Using the old one is also an option but then we rely on the old package which we might want to remove/move in the future


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org