You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/24 17:24:30 UTC
[GitHub] [superset] GregOnEvo opened a new pull request #14575: fix: keyboard nav & focus in Explore control panel
GregOnEvo opened a new pull request #14575:
URL: https://github.com/apache/superset/pull/14575
### SUMMARY
Provides better keyboard navigation in control panel of Explore view. Allows `Label`-styled buttons and `Checkbox`es to focused & interacted with using keyboard. Emulates browser form label click behavior on `ControlHeader`s: focus, and for `Checkbox`es, select.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
### TEST PLAN
Navigate control panel using Tab/Shift-Tab; focus should visibly move in a sensible way.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: Fixes #14574
- [X] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas edited a comment on pull request #14575: fix: keyboard nav & focus in Explore control panel
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #14575:
URL: https://github.com/apache/superset/pull/14575#issuecomment-890432305
you can run `npm run lint-fix` in your console to fix the linting errors. The CI run also indicates it needs some TS attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] GregOnEvo commented on pull request #14575: fix: keyboard nav & focus in Explore control panel
Posted by GitBox <gi...@apache.org>.
GregOnEvo commented on pull request #14575:
URL: https://github.com/apache/superset/pull/14575#issuecomment-891232908
Thanks for taking a look, should be better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #14575: fix: keyboard nav & focus in Explore control panel
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #14575:
URL: https://github.com/apache/superset/pull/14575#discussion_r637960492
##########
File path: superset-frontend/src/explore/components/controls/TextControl/index.tsx
##########
@@ -27,6 +27,7 @@ type InputValueType = string | number;
export interface TextControlProps<T extends InputValueType = InputValueType> {
label?: string;
+ name?: string;
Review comment:
It seems that name should not be optional to promote the correct usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #14575: fix: keyboard nav & focus in Explore control panel
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #14575:
URL: https://github.com/apache/superset/pull/14575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #14575: fix: keyboard nav & focus in Explore control panel
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #14575:
URL: https://github.com/apache/superset/pull/14575#issuecomment-890432305
you can run `npm run lint-fix` in your console to fix the linting errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #14575: fix: keyboard nav & focus in Explore control panel
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #14575:
URL: https://github.com/apache/superset/pull/14575#issuecomment-890431778
Not sure how this slipped under my radar for so long, but I appreciate this effort and will try to take a closer look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org