You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/04/24 14:15:32 UTC
Review Request 58667: Ambari agents can only connect to the server
using TLSv1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58667/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
Bugs: AMBARI-20831
https://issues.apache.org/jira/browse/AMBARI-20831
Repository: ambari
Description
-------
ability to configure ssl version for agent
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ae938dc
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 57416a4
ambari-agent/src/main/python/ambari_agent/NetUtil.py 2e9381b
ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py c9724b7
ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761
ambari-common/src/main/python/resource_management/libraries/script/script.py 1c5bdce
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py ddeb116
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7514918
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 737ae04
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 107ad7c
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py 49cfa86
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/service_check.py 81d7ca5
Diff: https://reviews.apache.org/r/58667/diff/1/
Testing
-------
mvn clean test
Thanks,
Eugene Chekanskiy
Re: Review Request 58667: Ambari agents can only connect to the
server using TLSv1
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58667/#review172784
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py
Line 47 (original), 48 (patched)
<https://reviews.apache.org/r/58667/#comment245827>
Fix comment to indicate the retry will be using the _forced_ protocol.
- Robert Levas
On April 24, 2017, 10:15 a.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58667/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 10:15 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20831
> https://issues.apache.org/jira/browse/AMBARI-20831
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ability to configure ssl version for agent
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ae938dc
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 57416a4
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 2e9381b
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py c9724b7
> ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761
> ambari-common/src/main/python/resource_management/libraries/script/script.py 1c5bdce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py ddeb116
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7514918
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 737ae04
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 107ad7c
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py 49cfa86
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/service_check.py 81d7ca5
>
>
> Diff: https://reviews.apache.org/r/58667/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 58667: Ambari agents can only connect to the
server using TLSv1
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58667/#review172783
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On \u041a\u0432\u0456\u0442\u0435\u043d\u044c 24, 2017, 2:15 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58667/
> -----------------------------------------------------------
>
> (Updated \u041a\u0432\u0456\u0442\u0435\u043d\u044c 24, 2017, 2:15 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20831
> https://issues.apache.org/jira/browse/AMBARI-20831
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ability to configure ssl version for agent
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ae938dc
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 57416a4
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 2e9381b
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py c9724b7
> ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761
> ambari-common/src/main/python/resource_management/libraries/script/script.py 1c5bdce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py ddeb116
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7514918
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 737ae04
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 107ad7c
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py 49cfa86
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/service_check.py 81d7ca5
>
>
> Diff: https://reviews.apache.org/r/58667/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 58667: Ambari agents can only connect to the
server using TLSv1
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58667/#review172807
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py
Lines 197 (patched)
<https://reviews.apache.org/r/58667/#comment245851>
instead of raising the exception, just log the message.
- Alejandro Fernandez
On April 24, 2017, 2:45 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58667/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 2:45 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20831
> https://issues.apache.org/jira/browse/AMBARI-20831
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ability to configure ssl version for agent
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ae938dc
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 57416a4
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 2e9381b
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py c9724b7
> ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761
> ambari-common/src/main/python/resource_management/libraries/script/script.py 1c5bdce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py ddeb116
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7514918
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 737ae04
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 107ad7c
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py 49cfa86
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/service_check.py 81d7ca5
>
>
> Diff: https://reviews.apache.org/r/58667/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 58667: Ambari agents can only connect to the
server using TLSv1
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58667/#review172787
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On April 24, 2017, 10:45 a.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58667/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 10:45 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20831
> https://issues.apache.org/jira/browse/AMBARI-20831
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ability to configure ssl version for agent
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ae938dc
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 57416a4
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 2e9381b
> ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py c9724b7
> ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761
> ambari-common/src/main/python/resource_management/libraries/script/script.py 1c5bdce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py ddeb116
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7514918
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 737ae04
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 107ad7c
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py 49cfa86
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/service_check.py 81d7ca5
>
>
> Diff: https://reviews.apache.org/r/58667/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 58667: Ambari agents can only connect to the
server using TLSv1
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58667/
-----------------------------------------------------------
(Updated April 24, 2017, 2:45 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodetskyi.
Bugs: AMBARI-20831
https://issues.apache.org/jira/browse/AMBARI-20831
Repository: ambari
Description
-------
ability to configure ssl version for agent
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ae938dc
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 57416a4
ambari-agent/src/main/python/ambari_agent/NetUtil.py 2e9381b
ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py c9724b7
ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761
ambari-common/src/main/python/resource_management/libraries/script/script.py 1c5bdce
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py ddeb116
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7514918
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 737ae04
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 107ad7c
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py 49cfa86
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/service_check.py 81d7ca5
Diff: https://reviews.apache.org/r/58667/diff/2/
Changes: https://reviews.apache.org/r/58667/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Eugene Chekanskiy