You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/11/12 16:38:33 UTC

[jira] [Commented] (FLINK-1221) Use program source line of invocation as the default function name

    [ https://issues.apache.org/jira/browse/FLINK-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208147#comment-14208147 ] 

ASF GitHub Bot commented on FLINK-1221:
---------------------------------------

GitHub user rmetzger opened a pull request:

    https://github.com/apache/incubator-flink/pull/197

    [FLINK-1221] Use the source line as the default operator name

    Before this change, we were using the class name for naming transformations.
    
    With the change, we use the line of code where the dataset transformation is being called.
    For example `org.apache.flink.api.java.operators.NamesTest.testJoinWith(NamesTest.java:92)` would be a name of a Join.
    
    All this applies only if the user does not specify a name.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/incubator-flink flink1221

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #197
    
----
commit 020710111fb1ea334cee6720f0efc3eef70b9d40
Author: Robert Metzger <rm...@apache.org>
Date:   2014-11-11T16:30:09Z

    [FLINK-1221] Use the source line as the default operator name

----


> Use program source line of invocation  as the default function name
> -------------------------------------------------------------------
>
>                 Key: FLINK-1221
>                 URL: https://issues.apache.org/jira/browse/FLINK-1221
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 0.8-incubating
>            Reporter: Stephan Ewen
>            Assignee: Robert Metzger
>            Priority: Minor
>             Fix For: 0.8-incubating
>
>
> Right now, the default function name is {{getClass().getName()}}.
> In many cases, this is not really very revealing. Using line in the source code where the function is invoked is more helpful.
> This can be easily obtained by
> {code}
> Thread.getCurrentThread().getStackTrace()[0]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)