You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Daniel Kulp (JIRA)" <ji...@apache.org> on 2012/10/02 16:57:07 UTC

[jira] [Created] (GERONIMO-6394) saaj factories swollow the exceptions

Daniel Kulp created GERONIMO-6394:
-------------------------------------

             Summary: saaj factories swollow the exceptions
                 Key: GERONIMO-6394
                 URL: https://issues.apache.org/jira/browse/GERONIMO-6394
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: specs
            Reporter: Daniel Kulp
         Attachments: patch.txt


The various factories in the SAAJ specs jar do something like:
{code}
throw new SOAPException(exception.getMessage());
{code}

which causes just the message to propagate and not the full exception.  If the cause is something like an NPE, it's very hard to diagnose and fix.  Would suggest using:

{code}
throw new SOAPException(exception.getMessage(), exception);
{code}



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GERONIMO-6394) saaj factories swollow the exceptions

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp updated GERONIMO-6394:
----------------------------------

    Attachment: patch.txt
    
> saaj factories swollow the exceptions
> -------------------------------------
>
>                 Key: GERONIMO-6394
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6394
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: specs
>            Reporter: Daniel Kulp
>         Attachments: patch.txt
>
>
> The various factories in the SAAJ specs jar do something like:
> {code}
> throw new SOAPException(exception.getMessage());
> {code}
> which causes just the message to propagate and not the full exception.  If the cause is something like an NPE, it's very hard to diagnose and fix.  Would suggest using:
> {code}
> throw new SOAPException(exception.getMessage(), exception);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (GERONIMO-6394) saaj factories swollow the exceptions

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMO-6394.
-----------------------------------

    Resolution: Fixed
      Assignee: Jarek Gawor

Fixed in revision 1392958 (and published new snapshot). Thanks for the patch!

                
> saaj factories swollow the exceptions
> -------------------------------------
>
>                 Key: GERONIMO-6394
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6394
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: specs
>            Reporter: Daniel Kulp
>            Assignee: Jarek Gawor
>         Attachments: patch.txt
>
>
> The various factories in the SAAJ specs jar do something like:
> {code}
> throw new SOAPException(exception.getMessage());
> {code}
> which causes just the message to propagate and not the full exception.  If the cause is something like an NPE, it's very hard to diagnose and fix.  Would suggest using:
> {code}
> throw new SOAPException(exception.getMessage(), exception);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira