You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/04 16:40:16 UTC

[GitHub] [flink] zentol opened a new pull request #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

zentol opened a new pull request #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634
 
 
   Uses the same trick as #11633 to share a test resource across all modules, in this case `log4j-test.properties`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609058611
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158402369",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dd50c1369a74d7b5972620bf3f5b39bfea5434d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158402369) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
tillrohrmann edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609711858
 
 
   Thanks for creating this PR @zentol.
   
   From a software engineering standpoint I agree with these changes. It makes sense to reduce duplication.
   
   From a workflow perspective I think it worsens the situation a bit (or at least it disrupts the existing workflow). Currently when debugging a test from within the IDE, I jump to the test file, which brings me to the correct module, and then I change the `log4j2-test.properties` file in the resources folder of the test folder. This is quite easy and straight forward. With this change, now everyone has to remember that the `logj42-test.properties` comes from `flink-test-utils-junit` which is a higher intrinsic burden and not that obvious when you are new to the project.
   
   Before doing any changes, I advise to start a discussion on dev about this topic outlining the benefits and drawbacks as well as the implications for the devs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609438563
 
 
   > some modules seem to have some module specifics encoded in their logging config (I propose the keep the files for those modules)
   
   I would only have special configs in leaf modules. For modules that are depended on you will usually want these logging configs to be propagated. Like for `flink-runtime`. I can't think of a good reason to not use the same logging in `flink-tests`.
   
   I'm fine with keeping them in kafka and yarn-tests since they disable quite a lot (all of hadoop/zookeeper).
   
   > we need to make sure all the developers understand the new mechanism (I guess we should at least send a notice to the dev@ list?)
   
   yes, that was my plan.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609058611
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158402369",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dd50c1369a74d7b5972620bf3f5b39bfea5434d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158402369) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609058611
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dd50c1369a74d7b5972620bf3f5b39bfea5434d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609058611
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158402369",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dd50c1369a74d7b5972620bf3f5b39bfea5434d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158402369) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068) 
   * 13fa6c241989f1d3479c1b26233362e5be2f9983 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#discussion_r403707044
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-0.10/src/test/resources/log4j2-test.properties
 ##########
 @@ -1,38 +0,0 @@
-################################################################################
-#  Licensed to the Apache Software Foundation (ASF) under one
-#  or more contributor license agreements.  See the NOTICE file
-#  distributed with this work for additional information
-#  regarding copyright ownership.  The ASF licenses this file
-#  to you under the Apache License, Version 2.0 (the
-#  "License"); you may not use this file except in compliance
-#  with the License.  You may obtain a copy of the License at
-#
-#      http://www.apache.org/licenses/LICENSE-2.0
-#
-#  Unless required by applicable law or agreed to in writing, software
-#  distributed under the License is distributed on an "AS IS" BASIS,
-#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#  See the License for the specific language governing permissions and
-# limitations under the License.
-################################################################################
-
-# Set root logger level to OFF to not flood build logs
-# set manually to INFO for debugging purposes
-rootLogger.level = OFF
-rootLogger.appenderRef.test.ref = TestLogger
-
-appender.testlogger.name = TestLogger
-appender.testlogger.type = CONSOLE
-appender.testlogger.target = SYSTEM_ERR
-appender.testlogger.layout.type = PatternLayout
-appender.testlogger.layout.pattern = %-4r [%t] %-5p %c %x - %m%n
-
-logger.kafka.name = kafka
-logger.kafka.level = OFF
-logger.kafka2.name = state.change
-logger.kafka2.level = OFF
-
-logger.zookeeper.name = org.apache.zookeeper
-logger.zookeeper.level = OFF
-logger.I0Itec.name = org.I0Itec
-logger.I0Itec.level = OFF
 
 Review comment:
   I wonder if it makes sense to keep the file around if there's some domain knowledge in those files. I guess for debugging or working on the Kafka tests it is helpful to suppress some log outputs. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609058611
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158402369",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7093",
       "triggerID" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158631557",
       "triggerID" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 13fa6c241989f1d3479c1b26233362e5be2f9983 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158631557) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7093) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609058611
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158402369",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7093",
       "triggerID" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158631557",
       "triggerID" : "13fa6c241989f1d3479c1b26233362e5be2f9983",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dd50c1369a74d7b5972620bf3f5b39bfea5434d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158402369) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068) 
   * 13fa6c241989f1d3479c1b26233362e5be2f9983 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158631557) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7093) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609711858
 
 
   Thanks for creating this PR @zentol.
   
   From a software engineering standpoint I agree with these changes. It makes sense to reduce duplication.
   
   From a workflow perspective I think it worsens the situation a bit (or at least it disrupts the existing workflow). Currently when debugging a test from within the IDE, I jump to the test file, which brings me to the correct module, and then I change the `log4j2-test.properties` file in the resources folder of the test folder. This is quite easy and straight forward. With this change, now everyone has to remember that the `logj42-test.properties` comes from `flink-test-utils-junit` which is a higher intrinsic burden and not that obvious when you are new to the project.
   
   Before doing any changes, I strongly advise to start a discussion on dev about this topic. Making this change and then letting people know is not the right way forward from here on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#discussion_r403707157
 
 

 ##########
 File path: flink-runtime/src/test/resources/log4j2-test.properties
 ##########
 @@ -1,32 +0,0 @@
-################################################################################
-#  Licensed to the Apache Software Foundation (ASF) under one
-#  or more contributor license agreements.  See the NOTICE file
-#  distributed with this work for additional information
-#  regarding copyright ownership.  The ASF licenses this file
-#  to you under the Apache License, Version 2.0 (the
-#  "License"); you may not use this file except in compliance
-#  with the License.  You may obtain a copy of the License at
-#
-#      http://www.apache.org/licenses/LICENSE-2.0
-#
-#  Unless required by applicable law or agreed to in writing, software
-#  distributed under the License is distributed on an "AS IS" BASIS,
-#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#  See the License for the specific language governing permissions and
-# limitations under the License.
-################################################################################
-
-# Set root logger level to OFF to not flood build logs
-# set manually to INFO for debugging purposes
-rootLogger.level = OFF
-rootLogger.appenderRef.test.ref = TestLogger
-
-appender.testlogger.name = TestLogger
-appender.testlogger.type = CONSOLE
-appender.testlogger.target = SYSTEM_ERR
-appender.testlogger.layout.type = PatternLayout
-appender.testlogger.layout.pattern = %-4r [%t] %-5p %c %x - %m%n
-
-# Resource leak detetor only works with logging enabled at error level
-logger.netty.name = org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector
-logger.netty.level = ERROR
 
 Review comment:
   I guess we want the ResourceLeakDetector enabled for the tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609055897
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4dd50c1369a74d7b5972620bf3f5b39bfea5434d (Sat Apr 04 16:42:43 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11634: [FLINK-16984][tests] Consolidate Log4j2-test.properties
URL: https://github.com/apache/flink/pull/11634#issuecomment-609058611
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158402369",
       "triggerID" : "4dd50c1369a74d7b5972620bf3f5b39bfea5434d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dd50c1369a74d7b5972620bf3f5b39bfea5434d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158402369) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7068) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services