You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/16 15:27:46 UTC

[GitHub] [kafka] guozhangwang commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset 【WIP】

guozhangwang commented on a change in pull request #8876:
URL: https://github.com/apache/kafka/pull/8876#discussion_r440941715



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -369,6 +369,7 @@ public static StreamThread create(final InternalTopologyBuilder builder,
 
         final Consumer<byte[], byte[]> mainConsumer = clientSupplier.getConsumer(consumerConfigs);
         changelogReader.setMainConsumer(mainConsumer);
+        changelogReader.setAdminClient(adminClient);

Review comment:
       Yeah that's the plan, I was just hacking it around so that I do not need to change 30+ unit tests. Once it is confirmed to fix the issue I will refactor this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org