[jira] [Commented] (AMBARI-20832) Desired configs fetched in loop via HostResourceProvider.getHosts

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-20832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981965#comment-15981965 ] 

Hadoop QA commented on AMBARI-20832:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12864769/AMBARI-20832.patch
  against trunk revision .

    {color:red}-1 patch{color}.  Top-level [trunk compilation|https://builds.apache.org/job/Ambari-trunk-test-patch/11467//artifact/patch-work/trunkJavacWarnings.txt] may be broken.

Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11467//console

This message is automatically generated.

> Desired configs fetched in loop via HostResourceProvider.getHosts
> -----------------------------------------------------------------
>
>                 Key: AMBARI-20832
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20832
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.2
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-20832.patch
>
>
> {{HostResourceProvider#getHosts}} always passes {{desiredConfigs=null}} (for the cluster) to {{Host#getDesiredHostConfigs}}, and it does so in a loop.  This is due to typo (not assigning to local variable) in:
> {noformat:title=HostResourceProvider.java}
>  654     // retrieve the cluster desired configs once instead of per host
>  655     Map<String, DesiredConfig> desiredConfigs = null;
>  656     if (null != cluster) {
>  657       cluster.getDesiredConfigs();
>  658     }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)