You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/23 02:24:38 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2244: [Enhancement] This method should use a StandardCharsets.XXX.name() to specify an encoding [NacosWebHookConfigOperation]
Alonexc opened a new issue, #2244:
URL: https://github.com/apache/incubator-eventmesh/issues/2244
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
org/apache/eventmesh/webhook/admin/NacosWebHookConfigOperation.java line 187
analysis and explanation:
This method uses a hand-typed String literal to specify a Charset encoding. As this class is compiled with JDK 7 (or better), and the charset in question is available as a constant from the java.nio.charset.StandardCharsets class, it is better to use the .name() method of the appropriate StandardCharsets constant.
The method in question doesn't directly support a Charset as a parameter, only a String. Still, instead of specifying something like "UTF-8" (and potentially mistyping it), use StandardCharsets.UTF_8.name().
### Describe the solution you'd like
Change to use StandardCharsets.UTF_8.name().
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] LIU-WEI-git closed issue #2244: [Enhancement] This method should use a StandardCharsets.XXX.name() to specify an encoding [NacosWebHookConfigOperation]
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git closed issue #2244: [Enhancement] This method should use a StandardCharsets.XXX.name() to specify an encoding [NacosWebHookConfigOperation]
URL: https://github.com/apache/incubator-eventmesh/issues/2244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org