You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/02 04:49:31 UTC

[GitHub] [bookkeeper] michaeljmarshall commented on a change in pull request #2630: [doc] fix the no striping occurs condition to Qw=E

michaeljmarshall commented on a change in pull request #2630:
URL: https://github.com/apache/bookkeeper/pull/2630#discussion_r585249009



##########
File path: site/docs/4.10.0/development/protocol.md
##########
@@ -64,7 +64,7 @@ Entry | Write quorum
 4 | B1, B2, B3
 5 | B2, B3, B4
 
-There are only **E** distinct write quorums in any ensemble. If **Q<sub>w</sub>** = **Q<sub>a</sub>**, then there is only one, as no striping occurs.
+There are only **E** distinct write quorums in any ensemble. If **Q<sub>w</sub>** = **E**, then there is only one, as no striping occurs.

Review comment:
       @dlg99 - thanks for your comment. I think what I wrote is consistent with your comment, please let me know if you think otherwise.
   
   > There is no striping in case of (E, Qw, Qa) == (3, ,3 ,3) or (3, 3, 2).
   
   In both cases above, E = Qw, and there is only 1 distinct write quorum.
   
   > There is striping in case of (5, 3, 3)
   
   In this case, E > Qw, and there are E distinct write quorums.
   
   My only point is that I think the documentation would be clearer as a single sentence (with an obvious either/or relationship) instead of two.
   
   No worries if we leave it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org