You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "frankgh (via GitHub)" <gi...@apache.org> on 2025/07/27 01:34:11 UTC
[PR] CASSSIDECAR-1: Sidecar gradle run should not run integration tests [cassandra-sidecar]
frankgh opened a new pull request, #240:
URL: https://github.com/apache/cassandra-sidecar/pull/240
Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-1: Sidecar gradle run should not run integration tests [cassandra-sidecar]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #240:
URL: https://github.com/apache/cassandra-sidecar/pull/240#discussion_r2233745411
##########
build.gradle:
##########
@@ -323,6 +325,33 @@ tasks.register('copyDocs', Copy) {
exclude "tmp"
}
+// Exclude some tasks to speed up running ./gradlew run
+if ("run" in gradle.startParameter.taskNames) {
+ project.gradle.startParameter.excludedTaskNames.add("codeCheckTasks")
+ project.gradle.startParameter.excludedTaskNames.add("asciidoctor")
+}
+
+gradle.taskGraph.whenReady { taskGraph ->
+ if ("run" in gradle.startParameter.taskNames) {
+ def exclusionTasks = tasks.findAll {
+ // integration tests
+ it.name == "integrationTest" ||
+ // distribution plugin tasks
+ it.name.startsWith('dist') || it.name.startsWith('assembleDist') ||
+ // tar, deb, zip, rpm tasks
+ it.name.endsWith("Tar") || it.name.endsWith("Deb") || it.name.endsWith("Rpm") || it.name.endsWith("Zip") ||
+ // docs
+ it.name.contains("asciidoctor") || it.name == "copyDocs" ||
+ // other tasks
+ it.name.startsWith("spotbugs") || it.name == "rat"
Review Comment:
Can you use the continuation indent of 0, instead of 8? To be the same as Java.
##########
build.gradle:
##########
@@ -323,6 +325,33 @@ tasks.register('copyDocs', Copy) {
exclude "tmp"
}
+// Exclude some tasks to speed up running ./gradlew run
+if ("run" in gradle.startParameter.taskNames) {
+ project.gradle.startParameter.excludedTaskNames.add("codeCheckTasks")
+ project.gradle.startParameter.excludedTaskNames.add("asciidoctor")
+}
+
+gradle.taskGraph.whenReady { taskGraph ->
Review Comment:
good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-1: Sidecar gradle run should not run integration tests [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #240:
URL: https://github.com/apache/cassandra-sidecar/pull/240#discussion_r2234054505
##########
build.gradle:
##########
@@ -323,6 +325,33 @@ tasks.register('copyDocs', Copy) {
exclude "tmp"
}
+// Exclude some tasks to speed up running ./gradlew run
+if ("run" in gradle.startParameter.taskNames) {
+ project.gradle.startParameter.excludedTaskNames.add("codeCheckTasks")
+ project.gradle.startParameter.excludedTaskNames.add("asciidoctor")
+}
+
+gradle.taskGraph.whenReady { taskGraph ->
+ if ("run" in gradle.startParameter.taskNames) {
+ def exclusionTasks = tasks.findAll {
+ // integration tests
+ it.name == "integrationTest" ||
+ // distribution plugin tasks
+ it.name.startsWith('dist') || it.name.startsWith('assembleDist') ||
+ // tar, deb, zip, rpm tasks
+ it.name.endsWith("Tar") || it.name.endsWith("Deb") || it.name.endsWith("Rpm") || it.name.endsWith("Zip") ||
+ // docs
+ it.name.contains("asciidoctor") || it.name == "copyDocs" ||
+ // other tasks
+ it.name.startsWith("spotbugs") || it.name == "rat"
Review Comment:
this is automatically indented, but I can manually update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-1: Sidecar gradle run should not run integration tests [cassandra-sidecar]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #240:
URL: https://github.com/apache/cassandra-sidecar/pull/240#discussion_r2234056347
##########
build.gradle:
##########
@@ -323,6 +325,33 @@ tasks.register('copyDocs', Copy) {
exclude "tmp"
}
+// Exclude some tasks to speed up running ./gradlew run
+if ("run" in gradle.startParameter.taskNames) {
+ project.gradle.startParameter.excludedTaskNames.add("codeCheckTasks")
+ project.gradle.startParameter.excludedTaskNames.add("asciidoctor")
+}
+
+gradle.taskGraph.whenReady { taskGraph ->
+ if ("run" in gradle.startParameter.taskNames) {
+ def exclusionTasks = tasks.findAll {
+ // integration tests
+ it.name == "integrationTest" ||
+ // distribution plugin tasks
+ it.name.startsWith('dist') || it.name.startsWith('assembleDist') ||
+ // tar, deb, zip, rpm tasks
+ it.name.endsWith("Tar") || it.name.endsWith("Deb") || it.name.endsWith("Rpm") || it.name.endsWith("Zip") ||
+ // docs
+ it.name.contains("asciidoctor") || it.name == "copyDocs" ||
+ // other tasks
+ it.name.startsWith("spotbugs") || it.name == "rat"
Review Comment:
yep. The project does not have the style setting for groovy. Maybe update the `ide/idea/codeStyleSettings.xml` to include the following too.
```xml
<codeStyleSettings language="Groovy">
<indentOptions>
<option name="CONTINUATION_INDENT_SIZE" value="0" />
</indentOptions>
</codeStyleSettings>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-1: Sidecar gradle run should not run integration tests [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #240:
URL: https://github.com/apache/cassandra-sidecar/pull/240#discussion_r2234166017
##########
build.gradle:
##########
@@ -323,6 +325,33 @@ tasks.register('copyDocs', Copy) {
exclude "tmp"
}
+// Exclude some tasks to speed up running ./gradlew run
+if ("run" in gradle.startParameter.taskNames) {
+ project.gradle.startParameter.excludedTaskNames.add("codeCheckTasks")
+ project.gradle.startParameter.excludedTaskNames.add("asciidoctor")
+}
+
+gradle.taskGraph.whenReady { taskGraph ->
+ if ("run" in gradle.startParameter.taskNames) {
+ def exclusionTasks = tasks.findAll {
+ // integration tests
+ it.name == "integrationTest" ||
+ // distribution plugin tasks
+ it.name.startsWith('dist') || it.name.startsWith('assembleDist') ||
+ // tar, deb, zip, rpm tasks
+ it.name.endsWith("Tar") || it.name.endsWith("Deb") || it.name.endsWith("Rpm") || it.name.endsWith("Zip") ||
+ // docs
+ it.name.contains("asciidoctor") || it.name == "copyDocs" ||
+ // other tasks
+ it.name.startsWith("spotbugs") || it.name == "rat"
Review Comment:
good idea, I've pushed the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-1: Sidecar gradle run should not run integration tests [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh merged PR #240:
URL: https://github.com/apache/cassandra-sidecar/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org