[GitHub] [druid] gianm commented on a diff in pull request #12627: split out null value index

[GitBox <gi...@apache.org>]

gianm commented on code in PR #12627:
URL: https://github.com/apache/druid/pull/12627#discussion_r894650357


##########
processing/src/main/java/org/apache/druid/segment/serde/DictionaryEncodedStringIndexSupplier.java:
##########
@@ -77,42 +78,45 @@ public DictionaryEncodedStringIndexSupplier(
     this.dictionaryUtf8 = dictionaryUtf8;
     this.bitmaps = bitmaps;
     this.indexedTree = indexedTree;
+    this.zeroIsNull = NullHandling.isNullOrEquivalent(dictionary.get(0));

Review Comment:
   Will this materially slow down historical startup time? If so: lazily compute instead of eagerly (like `minTime`, `maxTime` in QueryableIndexStorageAdapter).



##########
processing/src/main/java/org/apache/druid/segment/virtual/ListFilteredVirtualColumn.java:
##########
@@ -357,6 +357,30 @@ public ImmutableBitmap next()
     }
   }
 
+  private static class ListFilteredNullValueIndex extends BaseListFilteredColumnIndex implements NullValueIndex

Review Comment:
   Do we have tests for "is null" filters on ListFilteredVirtualColumn? If not, should add them as part of this patch since it's now its own code path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org