You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/09 00:58:47 UTC

Re: Review Request 54182: Improved various comments.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54182/#review158611
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp (line 2594)
<https://reviews.apache.org/r/54182/#comment229392>

    s/state/state and have all updates acknowledged/



src/master/master.cpp (line 5408)
<https://reviews.apache.org/r/54182/#comment229393>

    neglect to "remove" non-partition-aware?


- Vinod Kone


On Nov. 29, 2016, 10:36 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54182/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved various comments.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8 
>   src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a 
>   src/tests/partition_tests.cpp 5a0d4bd2de6a5aa0e9fdf0d34cd10d16fd4e34a1 
> 
> Diff: https://reviews.apache.org/r/54182/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>