You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/01 06:10:08 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request #5937: fs/epoll: support EPOLL full events
Donny9 opened a new pull request #5937:
URL: https://github.com/apache/incubator-nuttx/pull/5937
## Summary
fs/epoll: support EPOLL full events
Signed-off-by: Jiuzhu Dong <do...@xiaomi.com>
## Impact
support EPOLLHUP,EPOLLRDHUP,EPOLLONESHOT...
## Testing
local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5937: fs/epoll: change type of eventset from uint8_t to uint32_t
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5937:
URL: https://github.com/apache/incubator-nuttx/pull/5937#issuecomment-1086672362
@Donny9 please fix the printf warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5937: fs/epoll: change type of eventset from uint8_t to uint32_t
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5937:
URL: https://github.com/apache/incubator-nuttx/pull/5937#discussion_r840524829
##########
File path: arch/arm/src/cxd56xx/cxd56_geofence.c
##########
@@ -450,7 +450,7 @@ static void cxd56_geofence_sighandler(uint32_t data, FAR void *userdata)
if (fds)
{
fds->revents |= POLLIN;
- gnssinfo("Report events: %02x\n", fds->revents);
+ gnssinfo("Report events: %02" PRIx32 "\n", fds->revents);
Review comment:
```suggestion
gnssinfo("Report events: %08" PRIx32 "\n", fds->revents);
```
here and in other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5937: fs/epoll: support EPOLL full events
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5937:
URL: https://github.com/apache/incubator-nuttx/pull/5937#discussion_r840361060
##########
File path: fs/vfs/Kconfig
##########
@@ -60,3 +60,9 @@ config TIMER_FD_NPOLLWAITERS
Maximum number of threads that can be waiting on poll()
endif # TIMER_FD
+
+config EPOLL_FULLEVENTS
Review comment:
let's change events type instead add config option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #5937: fs/epoll: support EPOLL full events
Posted by GitBox <gi...@apache.org>.
Donny9 commented on a change in pull request #5937:
URL: https://github.com/apache/incubator-nuttx/pull/5937#discussion_r840421468
##########
File path: fs/vfs/Kconfig
##########
@@ -60,3 +60,9 @@ config TIMER_FD_NPOLLWAITERS
Maximum number of threads that can be waiting on poll()
endif # TIMER_FD
+
+config EPOLL_FULLEVENTS
Review comment:
Okay, Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #5937: fs/epoll: change type of eventset from uint8_t to uint32_t
Posted by GitBox <gi...@apache.org>.
Donny9 commented on a change in pull request #5937:
URL: https://github.com/apache/incubator-nuttx/pull/5937#discussion_r840563961
##########
File path: arch/arm/src/cxd56xx/cxd56_geofence.c
##########
@@ -450,7 +450,7 @@ static void cxd56_geofence_sighandler(uint32_t data, FAR void *userdata)
if (fds)
{
fds->revents |= POLLIN;
- gnssinfo("Report events: %02x\n", fds->revents);
+ gnssinfo("Report events: %02" PRIx32 "\n", fds->revents);
Review comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org