You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/09/01 17:31:10 UTC
Review Request 68600: Added a unit test for plugin crash during an
agent failover.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68600/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-8429
https://issues.apache.org/jira/browse/MESOS-8429
Repository: mesos
Description
-------
If a CSI plugin is crashed during agent failover, the residual socket
file would exist during SLRP recovery. This test verifies that the
plugin is properly cleaned up during recovery so the plugin can be
restarted.
Diffs
-----
src/examples/test_csi_plugin.cpp 93301f8af9b494bbcecb10e6cd4f4073b6a05070
src/tests/storage_local_resource_provider_tests.cpp 9d0020cb22d8f674c6271712a93db7f446824d55
Diff: https://reviews.apache.org/r/68600/diff/1/
Testing
-------
make check
NOTE: This test will fail without the following patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 68600: Added a unit test for plugin crash during
an agent failover.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68600/#review208233
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 1, 2018, 5:31 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68600/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2018, 5:31 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8429
> https://issues.apache.org/jira/browse/MESOS-8429
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a CSI plugin is crashed during agent failover, the residual socket
> file would exist during SLRP recovery. This test verifies that the
> plugin is properly cleaned up during recovery so the plugin can be
> restarted.
>
>
> Diffs
> -----
>
> src/examples/test_csi_plugin.cpp 93301f8af9b494bbcecb10e6cd4f4073b6a05070
> src/tests/storage_local_resource_provider_tests.cpp 9d0020cb22d8f674c6271712a93db7f446824d55
>
>
> Diff: https://reviews.apache.org/r/68600/diff/1/
>
>
> Testing
> -------
>
> make check
> NOTE: This test will fail without the following patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68600: Added a unit test for plugin crash during
an agent failover.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68600/#review208254
-----------------------------------------------------------
Ship it!
I'd suggest to commit this after or with the fixes from r/68601.
- Benjamin Bannier
On Sept. 1, 2018, 7:31 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68600/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2018, 7:31 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8429
> https://issues.apache.org/jira/browse/MESOS-8429
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a CSI plugin is crashed during agent failover, the residual socket
> file would exist during SLRP recovery. This test verifies that the
> plugin is properly cleaned up during recovery so the plugin can be
> restarted.
>
>
> Diffs
> -----
>
> src/examples/test_csi_plugin.cpp 93301f8af9b494bbcecb10e6cd4f4073b6a05070
> src/tests/storage_local_resource_provider_tests.cpp 9d0020cb22d8f674c6271712a93db7f446824d55
>
>
> Diff: https://reviews.apache.org/r/68600/diff/1/
>
>
> Testing
> -------
>
> make check
> NOTE: This test will fail without the following patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>