Re: [PR] CASSANDRA-21066 Full Repair for Tracked Keyspaces [cassandra]

["maedhroz (via GitHub)" <gi...@apache.org>]

maedhroz commented on code in PR #4565:
URL: https://github.com/apache/cassandra/pull/4565#discussion_r2750568302


##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -3056,6 +3057,15 @@ public Pair<Integer, Future<?>> repair(String keyspace, Map<String, String> repa
 
     public Pair<Integer, Future<?>> repair(String keyspace, RepairOption option, List<ProgressListener> listeners)
     {
+        KeyspaceMetadata ksm = Keyspace.open(keyspace).getMetadata();
+        if (ksm.params.replicationType.isTracked())
+        {
+            if (option.getPreviewKind() == PreviewKind.REPAIRED)
+                throw new IllegalArgumentException("Tracked keyspaces do not support validation repair");
+            if (option.isIncremental())
+                throw new IllegalArgumentException("Tracked keyspaces do not support incremental repair");

Review Comment:
   This breaks `StrictFilteringTest` and `PartialUpdateHandlingTest`. Either those tests will have to avoid IR for tracked keyspaces, or we'll have to get IR support and then rebase this branch on that...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org