[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2846: ARTEMIS-2500 CoreMessage doesn't make a ful copy of its props

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2846: ARTEMIS-2500 CoreMessage doesn't make a ful copy of its props
URL: https://github.com/apache/activemq-artemis/pull/2846#discussion_r326963829
 
 

 ##########
 File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
 ##########
 @@ -461,7 +461,7 @@ public void copyHeadersAndProperties(final Message msg) {
       priority = msg.getPriority();
 
       if (msg instanceof CoreMessage) {
-         properties = ((CoreMessage) msg).getProperties();
+         properties = new TypedProperties(((CoreMessage) msg).getProperties());
 
 Review comment:
   What's the use case here, the body is shared without deepclone. So if issues with properties surely same issue with body 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services