[GitHub] [airflow] kazanzhy commented on a change in pull request #20355: Set default logger in logging Mixin

[GitBox <gi...@apache.org>]

kazanzhy commented on a change in pull request #20355:
URL: https://github.com/apache/airflow/pull/20355#discussion_r774466346



##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -38,17 +39,15 @@ class LoggingMixin:
     """Convenience super-class to have a logger configured with the class name"""
 
     def __init__(self, context=None):
+        self._log: Optional[logging.Logger] = None
         self._set_context(context)
 
     @property
     def log(self) -> Logger:
         """Returns a logger."""
-        try:
-            # FIXME: LoggingMixin should have a default _log field.
-            return self._log  # type: ignore
-        except AttributeError:
+        if not hasattr(self, '_log') or self._log is None:

Review comment:
       Some of the classes that inherit from LoggingMixin don't call `super().__init__()`. 
   I counted above 5 of them.
   For that cases `hasattr` is needed. 
   I assume that `or self._log is None` could be deleted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org