You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/12/08 15:34:10 UTC
[PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]
kwin opened a new pull request, #48:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #48:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48#issuecomment-1852489308
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=48) **Quality Gate failed**
Failed conditions
[63.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-models-impl&pullRequest=48&metric=new_coverage&view=list) (required ≥ 80%)
[B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=48) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-models-impl&pullRequest=48)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #48:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48#issuecomment-1847393666
@stefanseifert The license headers were already mostly correct here (i.e. were not touched by spotless)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]
Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #48:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48#issuecomment-1851880092
i skimmed through the reformattings, some remarks:
* a lot of lines are reformatted into two or multiple lines because they seem to exceed a configured line lenght limit by a few chars. not sure what the configured values is, i have the feeling that with big screens available for most we should not limit this too much. and not the same limit is applied everywhere, e.g. comments behind `//` are reformatted wheres comments within `/* ... */`are not.
* log statements are reformatted to something like
```
log.warn(
"Unable to register model class {} because adapter class {} is not valid.",
clazz.getName(),
adapterClass.getName());
```
* i prefer putting `else {` after `}` on a new line instead of `} else {`
* i would not put a space after a casting expresssion as in `setConstructorParameter((ConstructorParameter) element, parameterValues, value)`
all of this points are matter of taste, of course. not sure if we want to finetune all those details or accept it as-is. it will be difficult to find a common sense anyway on lot of those points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin closed pull request #48: SLING-12186 PoC for spotless-maven-plugin
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #48:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48#issuecomment-1851889390
All is currently based on Palantir defaults https://github.com/palantir/palantir-java-format which explicitly states
> A modern, lambda-friendly, 120 character Java formatter.
We should really use a predefined formatter (maintaining our own set of rules feels like overkill although this is supported via https://github.com/diffplug/spotless/tree/main/plugin-maven#eclipse-jdt as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12186 PoC for spotless-maven-plugin [sling-org-apache-sling-models-impl]
Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #48:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/48#issuecomment-1851912233
ok, i will get used to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org