TEMP_DIR

[Markus Wichitill <ma...@gmx.de>]

Hi,

in apreq1, the TEMP_DIR parameter is usually ignored, since the tempnam()
function used prefers to place the files in the temp directory specified via
the TEMP/TMP environment variables. This was changed in apreq2, and after
looking at the code, I think it's supposed to actually honor TEMP_DIR if
specified. Alas, all my uploads end up in /tmp on Linux and c:\WinXP\Temp on
Windows. Can anybody verify this?

Re: TEMP_DIR

[Joe Schaefer <jo...@sunstarsys.com>]

Markus Wichitill <ma...@gmx.de> writes:

[...]

> If I change line 19 in request.pm to
> 
> my $req = Apache::Request->new($r, POST_MAX => 1000000, TEMP_DIR =>
> $temp_dir);
> 
> (i.e TEMP_DIR isn't the first option) tests 6-7 will fail.

Thanks Markus, cvs should be fixed now (will update the
tests shortly).

-- 
Joe Schaefer

Re: TEMP_DIR

[Markus Wichitill <ma...@gmx.de>]

> I can't.  New tests were added to request.pm that check the TEMP_DIR
> setting.  Running the tests in a shell which has exported TMPDIR=/tmp
> should have revealed the problem, but the tests pass for me either way.
> How about postiing some code that breaks for you?

If I change line 19 in request.pm to

my $req = Apache::Request->new($r, POST_MAX => 1000000, TEMP_DIR =>
$temp_dir);

(i.e TEMP_DIR isn't the first option) tests 6-7 will fail.

Re: TEMP_DIR

[Joe Schaefer <jo...@sunstarsys.com>]

Markus Wichitill <ma...@gmx.de> writes:

> This was changed in apreq2, and after looking at the code, I think
> it's supposed to actually honor TEMP_DIR if specified. Alas, all my 
> uploads end up in /tmp on Linux and c:\WinXP\Temp on Windows. Can
> anybody verify this?

I can't.  New tests were added to request.pm that check the TEMP_DIR
setting.  Running the tests in a shell which has exported TMPDIR=/tmp
should have revealed the problem, but the tests pass for me either way.

How about postiing some code that breaks for you?

-- 
Joe Schaefer