[GitHub] [iceberg] singhpk234 commented on a diff in pull request #4704: Spark: Support parallel delete files when abort

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #4704:
URL: https://github.com/apache/iceberg/pull/4704#discussion_r867298381


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -204,6 +205,7 @@ private void commitOperation(SnapshotUpdate<?> operation, String description) {
   private void abort(WriterCommitMessage[] messages) {
     Map<String, String> props = table.properties();
     Tasks.foreach(files(messages))
+        .executeWith(writeConf.deleteFilesParallelWhenAbort() ? ThreadPools.getWorkerPool() : null)

Review Comment:
   [question] does it makes sense to give it, it's own dedicated worker pool , Your thoughts ?



##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java:
##########
@@ -78,4 +78,6 @@ private SparkWriteOptions() {
 
   // Isolation Level for DataFrame calls. Currently supported by overwritePartitions
   public static final String ISOLATION_LEVEL = "isolation-level";
+
+  public static final String DELETE_FILES_PARALLEL_WHEN_ABORT = "delete-files-parallel-when-abort";

Review Comment:
   [minor] missing comment for this property



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org