You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@brightroll.com> on 2015/09/29 00:26:16 UTC

Re: Review Request 38689: SQOOP-2579

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38689/
-----------------------------------------------------------

(Updated Sept. 28, 2015, 10:26 p.m.)


Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2579
    https://issues.apache.org/jira/browse/SQOOP-2579


Repository: sqoop-sqoop2


Description
-------

Refactor RepositoryManager to not load structure from repository when loading jobs and links


Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 0bddf5b 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java b4c3d9b 
  core/src/main/java/org/apache/sqoop/repository/Repository.java c15c96d 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 7ab1182 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 1b0caf7 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 144b002 
  repository/repository-derby/pom.xml 2a3b8fc 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 5fd510d 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java b92e5e5 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java b34b588 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java f53c61a 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 9f8e570 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java e6cb9fb 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRepositoryUpgrade.java 9255882 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 79aced7 
  repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestJobHandling.java ed6543d 
  repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestLinkHandling.java db17124 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java 3a08268 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java 24de195 

Diff: https://reviews.apache.org/r/38689/diff/


Testing
-------

yes


Thanks,

Abraham Fine


Re: Review Request 38689: SQOOP-2579

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38689/#review100894
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Sept. 28, 2015, 10:26 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38689/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 10:26 p.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2579
>     https://issues.apache.org/jira/browse/SQOOP-2579
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Refactor RepositoryManager to not load structure from repository when loading jobs and links
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 0bddf5b 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java b4c3d9b 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java c15c96d 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 7ab1182 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 1b0caf7 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 144b002 
>   repository/repository-derby/pom.xml 2a3b8fc 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 5fd510d 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java b92e5e5 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java b34b588 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java f53c61a 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 9f8e570 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java e6cb9fb 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRepositoryUpgrade.java 9255882 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 79aced7 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestJobHandling.java ed6543d 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestLinkHandling.java db17124 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java 3a08268 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java 24de195 
> 
> Diff: https://reviews.apache.org/r/38689/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>