You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/07/03 14:10:51 UTC
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24543
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework the
complex-types SELECT * example, add an Impala 5.0.x incompatible-changes
entry, and clarify the Iceberg metadata-tables note.
- SelectStmt.java: refresh stale comments (the empty-select-list invariant
in analyzeStarItem still holds under the new default).
- AnalyzeStmtsTest / PlannerTest: run the cases that specifically exercise
the no-expand behavior with EXPAND_COMPLEX_TYPES=false.
- .test files: pin EXPAND_COMPLEX_TYPES=false on blocks that use the
collection-join syntax or are dedicated/paired complex-type tests; let
incidental 'SELECT *' tests adopt the new default
(virtual-column-file-position-parquet regenerated).
- ranger_column_masking_complex_types.test: regenerated for the new default.
SELECT * / STRUCT.* now return the complex columns
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
16 files changed, 130 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24543/1
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24543
to look at the new patch set (#7).
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework
the complex-types SELECT * example, add an Impala 5.0.x
incompatible-changes entry, and clarify the Iceberg metadata-tables
note.
- SelectStmt.java: refresh stale comments (the empty-select-list
invariant in analyzeStarItem still holds under the new default).
Test handling for the behaviour change. Where a query specifically uses
the collection-join/unnest syntax, expands a struct via '.*', or is a
dedicated/paired complex-type test, EXPAND_COMPLEX_TYPES is pinned to
false so the query keeps its previous meaning; incidental top-level
'SELECT *' tests adopt the new default and their expected results are
regenerated.
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/paimon-query.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
M tests/custom_cluster/test_lineage.py
M tests/query_test/test_kudu.py
25 files changed, 195 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24543/7
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 18:51:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13704/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 19:49:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24543/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24543/5//COMMIT_MSG@28
PS5, Line 28: Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
> This section is a bit chatty to me, these changes are clear from comments i
Removed this section, the above paragraph already summarizes the intent.
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jul 2026 16:24:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13698/
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Jul 2026 02:19:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24543
to look at the new patch set (#3).
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework
the complex-types SELECT * example, add an Impala 5.0.x
incompatible-changes entry, and clarify the Iceberg metadata-tables
note.
- SelectStmt.java: refresh stale comments (the empty-select-list
invariant in analyzeStarItem still holds under the new default).
Test handling for the behaviour change. Where a query specifically uses
the collection-join/unnest syntax, expands a struct via '.*', or is a
dedicated/paired complex-type test, EXPAND_COMPLEX_TYPES is pinned to
false so the query keeps its previous meaning; incidental top-level
'SELECT *' tests adopt the new default and their expected results are
regenerated.
- FE AnalyzerTest.TestVirtualColumnInputFileName and
AnalyzeStmtsTest.TestInsert: pin the affected queries via a no-expand
AnalysisContext ('*' + a self-unnested collection would otherwise
collide with the collection alias, and 'select *' on a text-format
table with complex columns would fail before the intended error).
- AnalyzeStmtsTest / PlannerTest: run the cases that specifically
exercise the no-expand behaviour with EXPAND_COMPLEX_TYPES=false;
empty.test pins the relative-table-ref '*' query via QUERYOPTIONS.
- .test files: pin EXPAND_COMPLEX_TYPES=false on the collection-join,
self-unnest, struct-'.*' and dedicated complex-type blocks in
nested-types-star-expansion, nested-types-tpch-mem-limit,
nested-types-subplan, nested-struct-in-select-list, max-nesting-depth,
paimon-query, ranger_row_filtering, iceberg-metadata-tables,
iceberg-migrated-table-field-id-resolution-complex and
iceberg-v3-negative.
- Incidental 'SELECT *' goldens regenerated for the new default
(virtual-column-file-position-parquet, iceberg-query's
iceberg_uppercase_col, ranger_column_masking_complex_types).
- test_lineage.py: run QueryTest/lineage with EXPAND_COMPLEX_TYPES=false
as a session option so the expected lineage graphs (and their query
hashes) stay valid without altering the recorded query text.
- test_kudu.py: disable EXPAND_COMPLEX_TYPES for the
'SELECT * ... UNNEST' check so '*' does not also expand the base
table's ARRAY columns.
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/paimon-query.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
M tests/custom_cluster/test_lineage.py
M tests/query_test/test_kudu.py
25 files changed, 183 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24543/3
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24543
to look at the new patch set (#5).
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework
the complex-types SELECT * example, add an Impala 5.0.x
incompatible-changes entry, and clarify the Iceberg metadata-tables
note.
- SelectStmt.java: refresh stale comments (the empty-select-list
invariant in analyzeStarItem still holds under the new default).
Test handling for the behaviour change. Where a query specifically uses
the collection-join/unnest syntax, expands a struct via '.*', or is a
dedicated/paired complex-type test, EXPAND_COMPLEX_TYPES is pinned to
false so the query keeps its previous meaning; incidental top-level
'SELECT *' tests adopt the new default and their expected results are
regenerated.
- AnalyzeStmtsTest.TestInsert: pin the affected query via a no-expand
AnalysisContext ('select *' on a text-format table with complex
columns would otherwise fail before the intended error).
- AnalyzeStmtsTest: move the cases that exercise the no-expand behaviour
into a dedicated TestDisableExpandComplexTypes test that sets
EXPAND_COMPLEX_TYPES=false.
- AnalyzerTest.TestVirtualColumnInputFileName and empty.test: alias the
self-unnested collection ref so the column expanded by '*' does not
collide with the collection alias, keeping EXPAND_COMPLEX_TYPES at its
new default.
- .test files: pin EXPAND_COMPLEX_TYPES=false where we need the
old behavior
- Incidental 'SELECT *' goldens regenerated for the new default
- test_lineage.py: run QueryTest/lineage with EXPAND_COMPLEX_TYPES=false
as a session option so the expected lineage graphs (and their query
hashes) stay valid without altering the recorded query text.
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/paimon-query.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
M tests/custom_cluster/test_lineage.py
M tests/query_test/test_kudu.py
25 files changed, 201 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24543/5
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24543
to look at the new patch set (#6).
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework
the complex-types SELECT * example, add an Impala 5.0.x
incompatible-changes entry, and clarify the Iceberg metadata-tables
note.
- SelectStmt.java: refresh stale comments (the empty-select-list
invariant in analyzeStarItem still holds under the new default).
Test handling for the behaviour change. Where a query specifically uses
the collection-join/unnest syntax, expands a struct via '.*', or is a
dedicated/paired complex-type test, EXPAND_COMPLEX_TYPES is pinned to
false so the query keeps its previous meaning; incidental top-level
'SELECT *' tests adopt the new default and their expected results are
regenerated.
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/paimon-query.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
M tests/custom_cluster/test_lineage.py
M tests/query_test/test_kudu.py
25 files changed, 201 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24543/6
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
as there are no comments from others, upgrading to +2
left 2 nits about not too useful comments
http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@348
PS6, Line 348: // Alias the collection ref so that the 'int_array' column expanded by 'select *'
: // (EXPAND_COMPLEX_TYPES defaults to true) does not collide with the 'c.int_array'
: // collection alias.
Is this comment really useful?
http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test
File testdata/workloads/functional-planner/queries/PlannerTest/empty.test:
http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test@609
PS6, Line 609: # Alias the collection ref so that the c_orders array column expanded by 'select *'
: # (EXPAND_COMPLEX_TYPES defaults to true) does not collide with the c.c_orders
: # collection alias ("Duplicate table alias").
is this comment really useful?
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 14:58:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 4:
(6 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG@41
PS3, Line 41: ing the re
> nit: listing looks unnecessarily detailed
Done
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@893
PS2, Line 893: * EXPAND_COMPLEX_TYPES is set to false (it defaults to true);
> line too long (93 > 90)
Done
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1119
PS2, Line 1119: AnalyzesOk("select complex_struct_col.* from functional.allcomplextypes",
> line too long (91 > 90)
Done
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4794
PS2, Line 4794: "support inserting into tables containing complex type columns");
> line too long (91 > 90)
Done
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test:
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@1178
PS3, Line 1178: f
> why 0? other places use false
Done
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test:
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test@47
PS3, Line 47: set expand_complex_types=true;
> I saw couple of places where it is set to true - can we remove these from t
This .test file is full of duplicated tests, I think it's good that the query option expand_complex_types is now explicit for each query. It makes the intent of the queries more clear.
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 08:42:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24543/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24543/5//COMMIT_MSG@28
PS5, Line 28: - AnalyzeStmtsTest.TestInsert: pin the affected query via a no-expand
This section is a bit chatty to me, these changes are clear from comments in the tests
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 14:37:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13698/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jul 2026 21:51:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24543
to look at the new patch set (#4).
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework
the complex-types SELECT * example, add an Impala 5.0.x
incompatible-changes entry, and clarify the Iceberg metadata-tables
note.
- SelectStmt.java: refresh stale comments (the empty-select-list
invariant in analyzeStarItem still holds under the new default).
Test handling for the behaviour change. Where a query specifically uses
the collection-join/unnest syntax, expands a struct via '.*', or is a
dedicated/paired complex-type test, EXPAND_COMPLEX_TYPES is pinned to
false so the query keeps its previous meaning; incidental top-level
'SELECT *' tests adopt the new default and their expected results are
regenerated.
- FE AnalyzerTest.TestVirtualColumnInputFileName and
AnalyzeStmtsTest.TestInsert: pin the affected queries via a no-expand
AnalysisContext ('*' + a self-unnested collection would otherwise
collide with the collection alias, and 'select *' on a text-format
table with complex columns would fail before the intended error).
- AnalyzeStmtsTest / PlannerTest: run the cases that specifically
exercise the no-expand behaviour with EXPAND_COMPLEX_TYPES=false;
empty.test pins the relative-table-ref '*' query via QUERYOPTIONS.
- .test files: pin EXPAND_COMPLEX_TYPES=false where we need the
old behavior
- Incidental 'SELECT *' goldens regenerated for the new default
- test_lineage.py: run QueryTest/lineage with EXPAND_COMPLEX_TYPES=false
as a session option so the expected lineage graphs (and their query
hashes) stay valid without altering the recorded query text.
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/paimon-query.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
M tests/custom_cluster/test_lineage.py
M tests/query_test/test_kudu.py
25 files changed, 183 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24543/4
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
Thanks for the review. Carry +2
http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@348
PS6, Line 348: AnalyzesOk(
: "select input__file__name, * from functional_parquet.complextypestbl c, " +
: "c.int_array arr
> Is this comment really useful?
Removed.
http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test
File testdata/workloads/functional-planner/queries/PlannerTest/empty.test:
http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test@609
PS6, Line 609: select * from tpch_nested_parquet.customer c, c.c_orders o limit 0
: ---- PLAN
: PLAN-ROOT SINK
> is this comment really useful?
Removed
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 08:43:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 2:
(4 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@893
PS2, Line 893: * EXPAND_COMPLEX_TYPES is set to false (it defaults to true); see addStarExpandedPath().
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1119
PS2, Line 1119: AnalyzesOk("select complex_struct_col.* from functional.allcomplextypes", ctxNoExpand);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4794
PS2, Line 4794: // EXPAND_COMPLEX_TYPES defaults to true; disable it so that 'select *' does not expand
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
File fe/src/test/java/org/apache/impala/planner/PlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@582
PS2, Line 582: // This file's golden lineage predates EXPAND_COMPLEX_TYPES defaulting to true; keep '*'
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jul 2026 21:52:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13693/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jul 2026 14:11:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24543
to look at the new patch set (#2).
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework
the complex-types SELECT * example, add an Impala 5.0.x
incompatible-changes entry, and clarify the Iceberg metadata-tables
note.
- SelectStmt.java: refresh stale comments (the empty-select-list
invariant in analyzeStarItem still holds under the new default).
Test handling for the behaviour change. Where a query specifically uses
the collection-join/unnest syntax, expands a struct via '.*', or is a
dedicated/paired complex-type test, EXPAND_COMPLEX_TYPES is pinned to
false so the query keeps its previous meaning; incidental top-level
'SELECT *' tests adopt the new default and their expected results are
regenerated.
- FE AnalyzerTest.TestVirtualColumnInputFileName and
AnalyzeStmtsTest.TestInsert: pin the affected queries via a no-expand
AnalysisContext ('*' + a self-unnested collection would otherwise
collide with the collection alias, and 'select *' on a text-format
table with complex columns would fail before the intended error).
- AnalyzeStmtsTest / PlannerTest: run the cases that specifically
exercise the no-expand behaviour with EXPAND_COMPLEX_TYPES=false;
empty.test pins the relative-table-ref '*' query via QUERYOPTIONS.
- .test files: pin EXPAND_COMPLEX_TYPES=false on the collection-join,
self-unnest, struct-'.*' and dedicated complex-type blocks in
nested-types-star-expansion, nested-types-tpch-mem-limit,
nested-types-subplan, nested-struct-in-select-list, max-nesting-depth,
paimon-query, ranger_row_filtering, iceberg-metadata-tables,
iceberg-migrated-table-field-id-resolution-complex and
iceberg-v3-negative.
- Incidental 'SELECT *' goldens regenerated for the new default
(virtual-column-file-position-parquet, iceberg-query's
iceberg_uppercase_col, ranger_column_masking_complex_types).
- test_lineage.py: run QueryTest/lineage with EXPAND_COMPLEX_TYPES=false
as a session option so the expected lineage graphs (and their query
hashes) stay valid without altering the recorded query text.
- test_kudu.py: disable EXPAND_COMPLEX_TYPES for the
'SELECT * ... UNNEST' check so '*' does not also expand the base
table's ARRAY columns.
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/paimon-query.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
M tests/custom_cluster/test_lineage.py
M tests/query_test/test_kudu.py
25 files changed, 181 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/24543/2
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 1:
(3 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:
http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@893
PS1, Line 893: * EXPAND_COMPLEX_TYPES is set to false (it defaults to true); see addStarExpandedPath().
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1119
PS1, Line 1119: AnalyzesOk("select complex_struct_col.* from functional.allcomplextypes", ctxNoExpand);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
File fe/src/test/java/org/apache/impala/planner/PlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@582
PS1, Line 582: // This file's golden lineage predates EXPAND_COMPLEX_TYPES defaulting to true; keep '*'
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jul 2026 14:12:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13771/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 08:43:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 08:43:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13703/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 10:24:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
Flips the default of the EXPAND_COMPLEX_TYPES query option from false to
true so that '*' expressions include complex-typed (ARRAY/MAP/STRUCT)
columns by default.
- common/thrift/Query.thrift: change the default to true.
- Docs: update the EXPAND_COMPLEX_TYPES default and rationale, rework
the complex-types SELECT * example, add an Impala 5.0.x
incompatible-changes entry, and clarify the Iceberg metadata-tables
note.
- SelectStmt.java: refresh stale comments (the empty-select-list
invariant in analyzeStarItem still holds under the new default).
Test handling for the behaviour change. Where a query specifically uses
the collection-join/unnest syntax, expands a struct via '.*', or is a
dedicated/paired complex-type test, EXPAND_COMPLEX_TYPES is pinned to
false so the query keeps its previous meaning; incidental top-level
'SELECT *' tests adopt the new default and their expected results are
regenerated.
Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Assisted-by: Claude Opus 4.8 (1M context) <no...@anthropic.com>
Reviewed-on: http://gerrit.cloudera.org:8080/24543
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/Query.thrift
M docs/topics/impala_complex_types.xml
M docs/topics/impala_expand_complex_types.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_incompatible_changes.xml
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-negative.test
M testdata/workloads/functional-query/queries/QueryTest/max-nesting-depth.test
M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/paimon-query.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test
M testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test
M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-parquet.test
M tests/custom_cluster/test_lineage.py
M tests/query_test/test_kudu.py
25 files changed, 195 insertions(+), 86 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13693/
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jul 2026 18:38:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1113
PS4, Line 1113: // EXPAND_COMPLEX_TYPES defaults to true, so use a context that sets it to false.
Maybe it would be clearer to move these to a new test like TestDisableExpandComplexTypes?
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1187
PS4, Line 1187: ctx.getQueryOptions().setExpand_complex_types(true);
could be removed - at this point it is misleading
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@349
PS4, Line 349: 'c.int_array' collection alias
couldn't simply give an alias to c.int_array? It doesn't change the intention of this test.
http://gerrit.cloudera.org:8080/#/c/24543/4/testdata/workloads/functional-planner/queries/PlannerTest/empty.test
File testdata/workloads/functional-planner/queries/PlannerTest/empty.test:
http://gerrit.cloudera.org:8080/#/c/24543/4/testdata/workloads/functional-planner/queries/PlannerTest/empty.test@609
PS4, Line 609: # EXPAND_COMPLEX_TYPES defaults to true; set it to false here because 'select *' would
: # otherwise expand the c_orders array column, which collides with the c.c_orders
: # collection alias ("Duplicate table alias").
Wouldn't an alias help?
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 06:36:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 5:
(4 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1113
PS4, Line 1113: // which requires EXPAND_COMPLEX_TYPES to be disabled (it defaults to true).
> Maybe it would be clearer to move these to a new test like TestDisableExpan
Done
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1187
PS4, Line 1187: AnalyzesOk(
> could be removed - at this point it is misleading
Done
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:
http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@349
PS4, Line 349: not collide with the 'c.int_a
> couldn't simply give an alias to c.int_array? It doesn't change the intenti
Done
http://gerrit.cloudera.org:8080/#/c/24543/4/testdata/workloads/functional-planner/queries/PlannerTest/empty.test
File testdata/workloads/functional-planner/queries/PlannerTest/empty.test:
http://gerrit.cloudera.org:8080/#/c/24543/4/testdata/workloads/functional-planner/queries/PlannerTest/empty.test@609
PS4, Line 609: # Alias the collection ref so that the c_orders array column expanded by 'select *'
: # (EXPAND_COMPLEX_TYPES defaults to true) does not collide with the c.c_orders
: # collection alias ("Duplicate table alias").
> Wouldn't an alias help?
Done
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 10:05:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 14:47:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 00:07:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG@41
PS3, Line 41: resolution
nit: listing looks unnecessarily detailed
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test:
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@1178
PS3, Line 1178: 0
why 0? other places use false
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test:
http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test@47
PS3, Line 47: set expand_complex_types=true;
I saw couple of places where it is set to true - can we remove these from the tests? This would also make it clear from the patch which test has an expanded pair, and which doesn't. It may be better to duplicate some tests and check both ways.
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 06:15:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15054: Set EXPAND COMPLEX TYPES to true by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 13:04:16 +0000
Gerrit-HasComments: No