You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Pavitra Subramaniam (JIRA)" <de...@myfaces.apache.org> on 2011/09/17 02:05:11 UTC
[jira] [Created] (TRINIDAD-2141) add a new 'browser-generic' agent
add a new 'browser-generic' agent
----------------------------------
Key: TRINIDAD-2141
URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
Project: MyFaces Trinidad
Issue Type: Improvement
Reporter: Pavitra Subramaniam
It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
We also would want this to have its own capabilities that any generic browser agent supports today.
This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
Any CSS rules with no @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (TRINIDAD-2141) add a new
'browser-generic' agent
Posted by "Pavitra Subramaniam (Issue Comment Edited) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116662#comment-13116662 ]
Pavitra Subramaniam edited comment on TRINIDAD-2141 at 9/28/11 6:21 PM:
------------------------------------------------------------------------
(JIRA2141-09282011.patch) uses the new name 'genericDesktop' for the agent.
was (Author: pasubra):
uses the new name 'genericDesktop' for the agent.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141 - 09282011.patch, JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Pavitra Subramaniam (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171401#comment-13171401 ]
Pavitra Subramaniam commented on TRINIDAD-2141:
-----------------------------------------------
Please commit the uploaded patch for trunk (JIRA-2141-12162011-trunk.patch) along with the patch uploaded to JIRA 2140
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA-2141-12.6.2-12082011.patch, JIRA-2141-12162011-trunk.patch, JIRA2141 - 09282011.patch, JIRA2141 - 10032011.patch, JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Jeanne Waldman (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119549#comment-13119549 ]
Jeanne Waldman commented on TRINIDAD-2141:
------------------------------------------
For now, if you would like to create a genericDesktop agent, you can simply call new AgentImpl() and set the intended values for platform/agentType/version etc. There is no request param to create the genericDesktop agent.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141 - 09282011.patch, JIRA2141 - 10032011.patch, JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Pavitra Subramaniam (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113849#comment-13113849 ]
Pavitra Subramaniam commented on TRINIDAD-2141:
-----------------------------------------------
The above patch introduces a new agent called 'browserGeneric' that will be the default agent when the output mode is set to be 'offline'. Please review the patch and commit it only after the patch for JIRA Issue 2140 has been committed, because these 2 changes work in conjunction.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106948#comment-13106948 ]
Scott O'Bryan commented on TRINIDAD-2141:
-----------------------------------------
I agree. But I do have a question.. I'm assuming this is plugin related? I'm not following the Archetype component or the fix version. Likely this should be the "effected version" and the component should probably be plugin or something.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Archetype
> Reporter: Pavitra Subramaniam
> Fix For: 1.2.14-plugins
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> Any CSS rules with no @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Jeanne Waldman (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116655#comment-13116655 ]
Jeanne Waldman commented on TRINIDAD-2141:
------------------------------------------
+1 for genericDesktop
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106942#comment-13106942 ]
Blake Sullivan commented on TRINIDAD-2141:
------------------------------------------
Trinidad already has a generic agent. However that agent is the least common denominator of all possible agents and therefore is too weak. I think that this proposal is to support a generic relatively powerful agent.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Archetype
> Reporter: Pavitra Subramaniam
> Fix For: 1.2.14-plugins
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> Any CSS rules with no @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Pavitra Subramaniam (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119543#comment-13119543 ]
Pavitra Subramaniam commented on TRINIDAD-2141:
-----------------------------------------------
My patch from 09-28 forces the agent to be genericDesktop when the outputMode=offline. This is not a good idea since outputMode alone cannot dictate the agent that gets used - ideally we would want to determine the agent to be used, through a request param - org.apache.myfaces.trinidad.agent=gecko. Removed the code in AgentFactoryImpl that creates the 'genericDesktop' agent.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141 - 09282011.patch, JIRA2141 - 10032011.patch, JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic' agent
Posted by Matt Cooper <mc...@apache.org>.
Works for me, thanks.
On Tue, Sep 27, 2011 at 1:05 PM, Blake Sullivan
<bl...@oracle.com>wrote:
> The definition is meant to be kept current. The definition is logically
> the least-common-denominator of the current set of desktop browsers back to
> IE7. If IE7 or some of the early versions of Safari were no longer setting
> the lower bar of capability, the capabilities would increase.
>
> -- Blake Sullivan
>
>
> On 9/27/11 11:32 AM, Scott O'Bryan wrote:
>
> -1 to timescale. In my experience, things that REQUIRE maintenance do not
> work well in OS..
>
> Scott
>
> On 09/27/2011 12:28 PM, Matt Cooper wrote:
>
> I'm okay with "genericDesktop".
>
> Perhaps this isn't a concern but I wonder if there is any value in giving
> any sort of time scale for this, e.g. genericDesktop2010 or
> genericDesktopHtml4, etc. as I presume in 2020 it'll be (I really hope
> so) nearly impossible to find an HTML display engine that doesn't display
> HTML5 markup at which point HTML5 will be considered "generic".
>
> Thanks,
> Matt
>
> On Tue, Sep 27, 2011 at 12:12 PM, Pavitra Subramaniam <
> pavitra.subramaniam@oracle.com> wrote:
>
>> On 9/27/2011 10:37 AM, Blake Sullivan (Commented) (JIRA) wrote:
>>
>>> [
>>> https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738]
>>>
>>> Blake Sullivan commented on TRINIDAD-2141:
>>> ------------------------------------------
>>>
>>> This isn't a generic agent (the 'unknown' agent is actually the 'most
>>> generic'), it is a generic, fairly rich desktop agent. I might go for
>>> genericDesktop.
>>>
>>>
>> +1. I prefer the lower camelcase 'genericDesktop" to "genericdesktop",
>> but it looks like the convention used differs
>>
>> - we already have a 'genericpda' / "nokia_s60" etc
>>
>>
>> Thanks
>> Pavitra
>>
>>
>>>
>>>
>>>> add a new 'browser-generic' agent
>>>> ----------------------------------
>>>>
>>>> Key: TRINIDAD-2141
>>>> URL:
>>>> https://issues.apache.org/jira/browse/TRINIDAD-2141
>>>> Project: MyFaces Trinidad
>>>> Issue Type: Improvement
>>>> Components: Infrastructure
>>>> Affects Versions: 1.2.15-core , 2.0.1-core
>>>> Reporter: Pavitra Subramaniam
>>>> Attachments: JIRA2141.patch
>>>>
>>>>
>>>> It would be very useful to have an agent called - 'browser-generic',
>>>> which represents the lowest common denominator agent for all browsers.
>>>> We also would want this to have its own capabilities that any generic
>>>> browser agent supports today.
>>>> This agent would be very useful in usecases where the user agent cannot
>>>> be determined at the time of rendering.
>>>> For example when rendering content for a page to be used as a file
>>>> attachment in an email, this could be very useful.
>>>> CSS rules with @agent keyword would be ignored.
>>>>
>>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA
>>> administrators:
>>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>> For more information on JIRA, see:
>>> http://www.atlassian.com/software/jira
>>>
>>>
>>>
>>>
>>
>
>
>
Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by Blake Sullivan <bl...@oracle.com>.
The definition is meant to be kept current. The definition is logically
the least-common-denominator of the current set of desktop browsers back
to IE7. If IE7 or some of the early versions of Safari were no longer
setting the lower bar of capability, the capabilities would increase.
-- Blake Sullivan
On 9/27/11 11:32 AM, Scott O'Bryan wrote:
> -1 to timescale. In my experience, things that REQUIRE maintenance do
> not work well in OS..
>
> Scott
>
> On 09/27/2011 12:28 PM, Matt Cooper wrote:
>> I'm okay with "genericDesktop".
>>
>> Perhaps this isn't a concern but I wonder if there is any value in
>> giving any sort of time scale for this, e.g. genericDesktop2010 or
>> genericDesktopHtml4, etc. as I presume in 2020 it'll be (I really
>> hope so) nearly impossible to find an HTML display engine that
>> doesn't display HTML5 markup at which point HTML5 will be considered
>> "generic".
>>
>> Thanks,
>> Matt
>>
>> On Tue, Sep 27, 2011 at 12:12 PM, Pavitra Subramaniam
>> <pavitra.subramaniam@oracle.com
>> <ma...@oracle.com>> wrote:
>>
>> On 9/27/2011 10:37 AM, Blake Sullivan (Commented) (JIRA) wrote:
>>
>> [
>> https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738
>> <https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738>
>> ]
>>
>> Blake Sullivan commented on TRINIDAD-2141:
>> ------------------------------------------
>>
>> This isn't a generic agent (the 'unknown' agent is actually
>> the 'most generic'), it is a generic, fairly rich desktop
>> agent. I might go for genericDesktop.
>>
>> +1. I prefer the lower camelcase 'genericDesktop" to
>> "genericdesktop", but it looks like the convention used differs
>>
>> - we already have a 'genericpda' / "nokia_s60" etc
>>
>>
>> Thanks
>> Pavitra
>>
>>
>>
>> add a new 'browser-generic' agent
>> ----------------------------------
>>
>> Key: TRINIDAD-2141
>> URL:
>> https://issues.apache.org/jira/browse/TRINIDAD-2141
>> Project: MyFaces Trinidad
>> Issue Type: Improvement
>> Components: Infrastructure
>> Affects Versions: 1.2.15-core , 2.0.1-core
>> Reporter: Pavitra Subramaniam
>> Attachments: JIRA2141.patch
>>
>>
>> It would be very useful to have an agent called -
>> 'browser-generic', which represents the lowest common
>> denominator agent for all browsers.
>> We also would want this to have its own capabilities that
>> any generic browser agent supports today.
>> This agent would be very useful in usecases where the
>> user agent cannot be determined at the time of rendering.
>> For example when rendering content for a page to be used
>> as a file attachment in an email, this could be very useful.
>> CSS rules with @agent keyword would be ignored.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your
>> JIRA administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> <https://issues.apache.org/jira/secure/ContactAdministrators%21default.jspa>
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
>>
>>
>
Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by Scott O'Bryan <da...@gmail.com>.
-1 to timescale. In my experience, things that REQUIRE maintenance do
not work well in OS..
Scott
On 09/27/2011 12:28 PM, Matt Cooper wrote:
> I'm okay with "genericDesktop".
>
> Perhaps this isn't a concern but I wonder if there is any value in
> giving any sort of time scale for this, e.g. genericDesktop2010 or
> genericDesktopHtml4, etc. as I presume in 2020 it'll be (I really hope
> so) nearly impossible to find an HTML display engine that doesn't
> display HTML5 markup at which point HTML5 will be considered "generic".
>
> Thanks,
> Matt
>
> On Tue, Sep 27, 2011 at 12:12 PM, Pavitra Subramaniam
> <pavitra.subramaniam@oracle.com
> <ma...@oracle.com>> wrote:
>
> On 9/27/2011 10:37 AM, Blake Sullivan (Commented) (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738
> <https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738>
> ]
>
> Blake Sullivan commented on TRINIDAD-2141:
> ------------------------------------------
>
> This isn't a generic agent (the 'unknown' agent is actually
> the 'most generic'), it is a generic, fairly rich desktop
> agent. I might go for genericDesktop.
>
> +1. I prefer the lower camelcase 'genericDesktop" to
> "genericdesktop", but it looks like the convention used differs
>
> - we already have a 'genericpda' / "nokia_s60" etc
>
>
> Thanks
> Pavitra
>
>
>
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL:
> https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141.patch
>
>
> It would be very useful to have an agent called -
> 'browser-generic', which represents the lowest common
> denominator agent for all browsers.
> We also would want this to have its own capabilities that
> any generic browser agent supports today.
> This agent would be very useful in usecases where the user
> agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used
> as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> <https://issues.apache.org/jira/secure/ContactAdministrators%21default.jspa>
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
>
Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic' agent
Posted by Matt Cooper <mc...@apache.org>.
I'm okay with "genericDesktop".
Perhaps this isn't a concern but I wonder if there is any value in giving
any sort of time scale for this, e.g. genericDesktop2010 or
genericDesktopHtml4, etc. as I presume in 2020 it'll be (I really hope
so) nearly impossible to find an HTML display engine that doesn't display
HTML5 markup at which point HTML5 will be considered "generic".
Thanks,
Matt
On Tue, Sep 27, 2011 at 12:12 PM, Pavitra Subramaniam <
pavitra.subramaniam@oracle.com> wrote:
> On 9/27/2011 10:37 AM, Blake Sullivan (Commented) (JIRA) wrote:
>
>> [ https://issues.apache.org/**jira/browse/TRINIDAD-2141?**
>> page=com.atlassian.jira.**plugin.system.issuetabpanels:**
>> comment-tabpanel&**focusedCommentId=13115738#**comment-13115738<https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738>]
>>
>> Blake Sullivan commented on TRINIDAD-2141:
>> ------------------------------**------------
>>
>> This isn't a generic agent (the 'unknown' agent is actually the 'most
>> generic'), it is a generic, fairly rich desktop agent. I might go for
>> genericDesktop.
>>
>>
> +1. I prefer the lower camelcase 'genericDesktop" to "genericdesktop", but
> it looks like the convention used differs
>
> - we already have a 'genericpda' / "nokia_s60" etc
>
>
> Thanks
> Pavitra
>
>
>>
>>
>>> add a new 'browser-generic' agent
>>> ------------------------------**----
>>>
>>> Key: TRINIDAD-2141
>>> URL: https://issues.apache.org/**
>>> jira/browse/TRINIDAD-2141<https://issues.apache.org/jira/browse/TRINIDAD-2141>
>>> Project: MyFaces Trinidad
>>> Issue Type: Improvement
>>> Components: Infrastructure
>>> Affects Versions: 1.2.15-core , 2.0.1-core
>>> Reporter: Pavitra Subramaniam
>>> Attachments: JIRA2141.patch
>>>
>>>
>>> It would be very useful to have an agent called - 'browser-generic',
>>> which represents the lowest common denominator agent for all browsers.
>>> We also would want this to have its own capabilities that any generic
>>> browser agent supports today.
>>> This agent would be very useful in usecases where the user agent cannot
>>> be determined at the time of rendering.
>>> For example when rendering content for a page to be used as a file
>>> attachment in an email, this could be very useful.
>>> CSS rules with @agent keyword would be ignored.
>>>
>>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators: https://issues.apache.org/**jira/secure/**
>> ContactAdministrators!default.**jspa<https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa>
>> For more information on JIRA, see: http://www.atlassian.com/**
>> software/jira <http://www.atlassian.com/software/jira>
>>
>>
>>
>>
>
Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by Blake Sullivan <bl...@oracle.com>.
Actually, that's because the committer who checked those in, did so with
no public review.
-- Blake Sullivan
On 9/27/11 11:12 AM, Pavitra Subramaniam wrote:
> On 9/27/2011 10:37 AM, Blake Sullivan (Commented) (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738
>> ]
>>
>> Blake Sullivan commented on TRINIDAD-2141:
>> ------------------------------------------
>>
>> This isn't a generic agent (the 'unknown' agent is actually the 'most
>> generic'), it is a generic, fairly rich desktop agent. I might go
>> for genericDesktop.
> +1. I prefer the lower camelcase 'genericDesktop" to "genericdesktop",
> but it looks like the convention used differs
>
> - we already have a 'genericpda' / "nokia_s60" etc
>
>
> Thanks
> Pavitra
>>
>>> add a new 'browser-generic' agent
>>> ----------------------------------
>>>
>>> Key: TRINIDAD-2141
>>> URL:
>>> https://issues.apache.org/jira/browse/TRINIDAD-2141
>>> Project: MyFaces Trinidad
>>> Issue Type: Improvement
>>> Components: Infrastructure
>>> Affects Versions: 1.2.15-core , 2.0.1-core
>>> Reporter: Pavitra Subramaniam
>>> Attachments: JIRA2141.patch
>>>
>>>
>>> It would be very useful to have an agent called - 'browser-generic',
>>> which represents the lowest common denominator agent for all browsers.
>>> We also would want this to have its own capabilities that any
>>> generic browser agent supports today.
>>> This agent would be very useful in usecases where the user agent
>>> cannot be determined at the time of rendering.
>>> For example when rendering content for a page to be used as a file
>>> attachment in an email, this could be very useful.
>>> CSS rules with @agent keyword would be ignored.
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by Pavitra Subramaniam <pa...@oracle.com>.
On 9/27/2011 10:37 AM, Blake Sullivan (Commented) (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738 ]
>
> Blake Sullivan commented on TRINIDAD-2141:
> ------------------------------------------
>
> This isn't a generic agent (the 'unknown' agent is actually the 'most generic'), it is a generic, fairly rich desktop agent. I might go for genericDesktop.
>
+1. I prefer the lower camelcase 'genericDesktop" to "genericdesktop",
but it looks like the convention used differs
- we already have a 'genericpda' / "nokia_s60" etc
Thanks
Pavitra
>
>
>> add a new 'browser-generic' agent
>> ----------------------------------
>>
>> Key: TRINIDAD-2141
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
>> Project: MyFaces Trinidad
>> Issue Type: Improvement
>> Components: Infrastructure
>> Affects Versions: 1.2.15-core , 2.0.1-core
>> Reporter: Pavitra Subramaniam
>> Attachments: JIRA2141.patch
>>
>>
>> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
>> We also would want this to have its own capabilities that any generic browser agent supports today.
>> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
>> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
>> CSS rules with @agent keyword would be ignored.
>>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Blake Sullivan (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115738#comment-13115738 ]
Blake Sullivan commented on TRINIDAD-2141:
------------------------------------------
This isn't a generic agent (the 'unknown' agent is actually the 'most generic'), it is a generic, fairly rich desktop agent. I might go for genericDesktop.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Scott O'Bryan (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168566#comment-13168566 ]
Scott O'Bryan commented on TRINIDAD-2141:
-----------------------------------------
Please provide a patch for 2.0.2
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA-2141-12.6.2-12082011.patch, JIRA2141 - 09282011.patch, JIRA2141 - 10032011.patch, JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (TRINIDAD-2141) add a new
'browser-generic' agent
Posted by "Pavitra Subramaniam (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113849#comment-13113849 ]
Pavitra Subramaniam edited comment on TRINIDAD-2141 at 9/24/11 2:17 AM:
------------------------------------------------------------------------
The above patch introduces a new agent called 'browserGeneric' that will be the default agent when the output mode is set to be 'offline'. Please review the patch and commit it into the private branch (jwaldman-offline-mode-branch) to test along with offline mode changes. This patch should be eventually merged into the affected versions along with the patch for JIRA Issue 2140 has been committed, because these 2 changes work in conjunction.
was (Author: pasubra):
The above patch introduces a new agent called 'browserGeneric' that will be the default agent when the output mode is set to be 'offline'. Please review the patch and commit it only after the patch for JIRA Issue 2140 has been committed, because these 2 changes work in conjunction.
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Pavitra Subramaniam (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115732#comment-13115732 ]
Pavitra Subramaniam commented on TRINIDAD-2141:
-----------------------------------------------
Another option is to simply call this 'generic' as the word 'browser' seems redundant.
Can folks vote on the following names for a generic powerful agent? Choices are
1. browser-generic / browserGeneric
2. generic
Any other suggestions?
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2141) add a new 'browser-generic' agent
Posted by "Pavitra Subramaniam (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavitra Subramaniam updated TRINIDAD-2141:
------------------------------------------
Status: Patch Available (was: Open)
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2141) add a new 'browser-generic' agent
Posted by "Matt Cooper (Updated) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Cooper updated TRINIDAD-2141:
----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1-core
Status: Resolved (was: Patch Available)
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Fix For: 2.0.1-core
>
> Attachments: JIRA-2141-12.6.2-12082011.patch, JIRA-2141-12162011-trunk.patch, JIRA2141 - 09282011.patch, JIRA2141 - 10032011.patch, JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic'
agent
Posted by "Pavitra Subramaniam (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113874#comment-13113874 ]
Pavitra Subramaniam commented on TRINIDAD-2141:
-----------------------------------------------
Note that we do not want to restrict the agent to 'browserGeneric' when the outputMode is 'offline' because in cases where an offline page is requested for particular agent we could use that agent when rendering. Also the patch introduces a new request parameter - "org.apache.myfaces.trinidad.outputMode".
> add a new 'browser-generic' agent
> ----------------------------------
>
> Key: TRINIDAD-2141
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2141
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: 1.2.15-core , 2.0.1-core
> Reporter: Pavitra Subramaniam
> Attachments: JIRA2141.patch
>
>
> It would be very useful to have an agent called - 'browser-generic', which represents the lowest common denominator agent for all browsers.
> We also would want this to have its own capabilities that any generic browser agent supports today.
> This agent would be very useful in usecases where the user agent cannot be determined at the time of rendering.
> For example when rendering content for a page to be used as a file attachment in an email, this could be very useful.
> CSS rules with @agent keyword would be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira