You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2024/07/05 17:47:49 UTC

(commons-statistics) 03/18: PMD fix: remove unnecessary cast

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 0b9c0655bed3d3ca88e51bfceac39db02db67d04
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Fri Jul 5 16:22:58 2024 +0100

    PMD fix: remove unnecessary cast
---
 .../commons/statistics/distribution/HypergeometricDistribution.java   | 4 ++--
 .../commons/statistics/distribution/UniformDiscreteDistribution.java  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java
index e8ed472..6d2a4b9 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java
@@ -72,8 +72,8 @@ public final class HypergeometricDistribution extends AbstractDiscreteDistributi
         this.sampleSize = sampleSize;
         lowerBound = getLowerDomain(populationSize, numberOfSuccesses, sampleSize);
         upperBound = getUpperDomain(numberOfSuccesses, sampleSize);
-        bp = (double) sampleSize / (double) populationSize;
-        bq = (double) (populationSize - sampleSize) / (double) populationSize;
+        bp = (double) sampleSize / populationSize;
+        bq = (double) (populationSize - sampleSize) / populationSize;
     }
 
     /**
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java
index d95dc99..19807a8 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java
@@ -57,7 +57,7 @@ public final class UniformDiscreteDistribution extends AbstractDiscreteDistribut
                                         int upper) {
         this.lower = lower;
         this.upper = upper;
-        upperMinusLowerPlus1 = (double) upper - (double) lower + 1;
+        upperMinusLowerPlus1 = (double) upper - lower + 1;
         pmf = 1.0 / upperMinusLowerPlus1;
         logPmf = -Math.log(upperMinusLowerPlus1);
         sf0 = (upperMinusLowerPlus1 - 1) / upperMinusLowerPlus1;
@@ -221,7 +221,7 @@ public final class UniformDiscreteDistribution extends AbstractDiscreteDistribut
     @Override
     public double getMean() {
         // Avoid overflow
-        return 0.5 * ((double) upper + (double) lower);
+        return 0.5 * ((double) upper + lower);
     }
 
     /**