You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "mnpoonia (via GitHub)" <gi...@apache.org> on 2026/10/05 16:31:18 UTC
[PR] HBASE-30458 Allow selecting the JDK version in dev-support/hbase_dock… [hbase]
mnpoonia opened a new pull request, #8738:
URL: https://github.com/apache/hbase/pull/8738
…er build
Add a --jdk 8|17|21 option to build-hbase.sh, passed to the Dockerfiles as the JDK_VERSION build arg. DEFAULT_JDK is 17 on master (8 on branch-2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30458 Allow selecting the JDK version in dev-support/hbase_dock… [hbase]
Posted by "mnpoonia (via GitHub)" <gi...@apache.org>.
mnpoonia commented on PR #8738:
URL: https://github.com/apache/hbase/pull/8738#issuecomment-6120648770
@virajjasani A gentle reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30458 Allow selecting the JDK version in dev-support/hbase_dock… [hbase]
Posted by "mnpoonia (via GitHub)" <gi...@apache.org>.
mnpoonia commented on code in PR #8738:
URL: https://github.com/apache/hbase/pull/8738#discussion_r4231618492
##########
dev-support/hbase_docker/build-hbase.sh:
##########
@@ -336,6 +352,35 @@ main() {
local value=""
local image_name="$DEFAULT_IMAGE_NAME"
+ # Extract --jdk (position-independent); the rest stays positional
+ local args=()
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ --jdk)
+ if [ $# -lt 2 ] || [ -z "$2" ]; then
+ echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)"
Review Comment:
Done, removed the ❌ in ed586165a72. Thanks!
##########
dev-support/hbase_docker/build-hbase.sh:
##########
@@ -336,6 +352,35 @@ main() {
local value=""
local image_name="$DEFAULT_IMAGE_NAME"
+ # Extract --jdk (position-independent); the rest stays positional
+ local args=()
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ --jdk)
+ if [ $# -lt 2 ] || [ -z "$2" ]; then
+ echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)"
+ exit 1
+ fi
+ JDK_VERSION="$2"
+ shift 2
+ ;;
+ --jdk=*)
+ JDK_VERSION="${1#--jdk=}"
+ shift
+ ;;
+ *)
+ args+=("$1")
+ shift
+ ;;
+ esac
+ done
+ set -- "${args[@]+"${args[@]}"}"
+
+ if [[ " $SUPPORTED_JDKS " != *" $JDK_VERSION "* ]]; then
+ echo "❌ ERROR: Unsupported JDK version: $JDK_VERSION (supported: $SUPPORTED_JDKS)"
Review Comment:
Done, removed the ❌ in ed586165a72. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30458 Allow selecting the JDK version in dev-support/hbase_dock… [hbase]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #8738:
URL: https://github.com/apache/hbase/pull/8738#discussion_r4188775710
##########
dev-support/hbase_docker/build-hbase.sh:
##########
@@ -336,6 +352,35 @@ main() {
local value=""
local image_name="$DEFAULT_IMAGE_NAME"
+ # Extract --jdk (position-independent); the rest stays positional
+ local args=()
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ --jdk)
+ if [ $# -lt 2 ] || [ -z "$2" ]; then
+ echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)"
+ exit 1
+ fi
+ JDK_VERSION="$2"
+ shift 2
+ ;;
+ --jdk=*)
+ JDK_VERSION="${1#--jdk=}"
+ shift
+ ;;
+ *)
+ args+=("$1")
+ shift
+ ;;
+ esac
+ done
+ set -- "${args[@]+"${args[@]}"}"
+
+ if [[ " $SUPPORTED_JDKS " != *" $JDK_VERSION "* ]]; then
+ echo "❌ ERROR: Unsupported JDK version: $JDK_VERSION (supported: $SUPPORTED_JDKS)"
Review Comment:
Same here
##########
dev-support/hbase_docker/build-hbase.sh:
##########
@@ -336,6 +352,35 @@ main() {
local value=""
local image_name="$DEFAULT_IMAGE_NAME"
+ # Extract --jdk (position-independent); the rest stays positional
+ local args=()
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ --jdk)
+ if [ $# -lt 2 ] || [ -z "$2" ]; then
+ echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)"
Review Comment:
Can we remove cross checkmark from echo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30458 Allow selecting the JDK version in dev-support/hbase_dock… [hbase]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #8738:
URL: https://github.com/apache/hbase/pull/8738#discussion_r4188773864
##########
dev-support/hbase_docker/build-hbase.sh:
##########
@@ -336,6 +352,35 @@ main() {
local value=""
local image_name="$DEFAULT_IMAGE_NAME"
+ # Extract --jdk (position-independent); the rest stays positional
+ local args=()
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ --jdk)
+ if [ $# -lt 2 ] || [ -z "$2" ]; then
+ echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)"
Review Comment:
Can we remove cross checkmark `❌` from the output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30458 Allow selecting the JDK version in dev-support/hbase_dock… [hbase]
Posted by "mnpoonia (via GitHub)" <gi...@apache.org>.
mnpoonia commented on PR #8738:
URL: https://github.com/apache/hbase/pull/8738#issuecomment-5998724286
@virajjasani @apurtell FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30458 Allow selecting the JDK version in dev-support/hbase_dock… [hbase]
Posted by "mnpoonia (via GitHub)" <gi...@apache.org>.
mnpoonia merged PR #8738:
URL: https://github.com/apache/hbase/pull/8738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org