You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/23 03:08:48 UTC

[GitHub] [apisix-website] bzp2010 opened a new pull request #624: chore: add preview branch condition

bzp2010 opened a new pull request #624:
URL: https://github.com/apache/apisix-website/pull/624


   Changes:
   
   Add branch restrictions for PR preview push CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #624: WIP: chore: add preview branch condition

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #624:
URL: https://github.com/apache/apisix-website/pull/624#issuecomment-925576136


   > Secrets are not passed into the fork repo, I don’t think this GitHub action would work as expected.
   
   Yes, Secrets are standalone, we could merge this first 🤔 to make it running as expected


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] kezhenxu94 commented on pull request #624: WIP: chore: add preview branch condition

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #624:
URL: https://github.com/apache/apisix-website/pull/624#issuecomment-925541804


   > Update:
   > Currently, we can't get the token through GitHub secret. We're looking for infra's help.
   
   Secrets are not passed into the fork repo, I don’t think this GitHub action would work as expected. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] kezhenxu94 commented on pull request #624: WIP: chore: add preview branch condition

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #624:
URL: https://github.com/apache/apisix-website/pull/624#issuecomment-925577971


   > > Secrets are not passed into the fork repo, I don’t think this GitHub action would work as expected.
   > 
   > Yes, Secrets are standalone, we could merge this first 🤔 to make it running as expected
   
   No. What I mean is that this GitHub Action will not work as expected. It aims at previewing the changes in pull requests, which are mostly opened from fork repos, that said, it mostly won’t be able to deploy a preview page due to the lack of privileges. . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] bzp2010 closed pull request #624: WIP: chore: add preview branch condition

Posted by GitBox <gi...@apache.org>.
bzp2010 closed pull request #624:
URL: https://github.com/apache/apisix-website/pull/624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] bzp2010 commented on pull request #624: WIP: chore: add preview branch condition

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #624:
URL: https://github.com/apache/apisix-website/pull/624#issuecomment-925514673


   Update:
   Currently, we can't get the token through GitHub secret. We're looking for infra's help.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org