You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2014/03/18 14:14:11 UTC
Review Request 19351: Fixed updating ipset on acquiring vm nic secondary ip
for advanced SG zone
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19351/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and edison su.
Bugs: CLOUDSTACK-6240
https://issues.apache.org/jira/browse/CLOUDSTACK-6240
Repository: cloudstack-git
Description
-------
Updated adding SG rules for nic secondary ips in Advacned SG.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239
Diff: https://reviews.apache.org/r/19351/diff/
Testing
-------
Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic
Thanks,
Jayapal Reddy
Re: Review Request 19351: Fixed updating ipset on acquiring vm nic secondary
ip for advanced SG zone
Posted by Jayapal Reddy <ja...@citrix.com>.
> On March 18, 2014, 6:25 p.m., Alena Prokharchyk wrote:
> > Jayapal, you shoudldn't rely on SG attribute of the zone. You should check if the SG service is supported by the network you are adding your rule to.
Updated patch to check network for SG enabled.
- Jayapal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19351/#review37589
-----------------------------------------------------------
On March 19, 2014, 11:59 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19351/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 11:59 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and edison su.
>
>
> Bugs: CLOUDSTACK-6240
> https://issues.apache.org/jira/browse/CLOUDSTACK-6240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Updated adding SG rules for nic secondary ips in Advacned SG.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239
> api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java 199cf2e
> server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 51c93b7
>
> Diff: https://reviews.apache.org/r/19351/diff/
>
>
> Testing
> -------
>
> Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request 19351: Fixed updating ipset on acquiring vm nic secondary
ip for advanced SG zone
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19351/#review37589
-----------------------------------------------------------
Jayapal, you shoudldn't rely on SG attribute of the zone. You should check if the SG service is supported by the network you are adding your rule to.
- Alena Prokharchyk
On March 18, 2014, 1:14 p.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19351/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 1:14 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and edison su.
>
>
> Bugs: CLOUDSTACK-6240
> https://issues.apache.org/jira/browse/CLOUDSTACK-6240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Updated adding SG rules for nic secondary ips in Advacned SG.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239
>
> Diff: https://reviews.apache.org/r/19351/diff/
>
>
> Testing
> -------
>
> Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request 19351: Fixed updating ipset on acquiring vm nic secondary
ip for advanced SG zone
Posted by Jayapal Reddy <ja...@citrix.com>.
> On March 18, 2014, 6:35 p.m., Alena Prokharchyk wrote:
> > Even for the Basic zone, we should send the ipSet command on nicplug only when the SG is supported by the Basic zone network. Because we also support a model when Basic zone is deployed with SG disabled.
When vm is created vm primary ip is set in ipset. For nic secondary ip there is no nicplug command send to hypervisor.
- Jayapal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19351/#review37596
-----------------------------------------------------------
On March 19, 2014, 11:59 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19351/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 11:59 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and edison su.
>
>
> Bugs: CLOUDSTACK-6240
> https://issues.apache.org/jira/browse/CLOUDSTACK-6240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Updated adding SG rules for nic secondary ips in Advacned SG.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239
> api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java 199cf2e
> server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 51c93b7
>
> Diff: https://reviews.apache.org/r/19351/diff/
>
>
> Testing
> -------
>
> Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request 19351: Fixed updating ipset on acquiring vm nic secondary
ip for advanced SG zone
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19351/#review37596
-----------------------------------------------------------
Even for the Basic zone, we should send the ipSet command on nicplug only when the SG is supported by the Basic zone network. Because we also support a model when Basic zone is deployed with SG disabled.
- Alena Prokharchyk
On March 18, 2014, 1:14 p.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19351/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 1:14 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and edison su.
>
>
> Bugs: CLOUDSTACK-6240
> https://issues.apache.org/jira/browse/CLOUDSTACK-6240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Updated adding SG rules for nic secondary ips in Advacned SG.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239
>
> Diff: https://reviews.apache.org/r/19351/diff/
>
>
> Testing
> -------
>
> Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request 19351: Fixed updating ipset on acquiring vm nic secondary
ip for advanced SG zone
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19351/#review37590
-----------------------------------------------------------
And the reason why you have to do so - in SG enabled Advance zone, you can have non-sg enabled networks. For those, the SG shouldn't be allowed to add.
- Alena Prokharchyk
On March 18, 2014, 1:14 p.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19351/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 1:14 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and edison su.
>
>
> Bugs: CLOUDSTACK-6240
> https://issues.apache.org/jira/browse/CLOUDSTACK-6240
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Updated adding SG rules for nic secondary ips in Advacned SG.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239
>
> Diff: https://reviews.apache.org/r/19351/diff/
>
>
> Testing
> -------
>
> Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request 19351: Fixed updating ipset on acquiring vm nic secondary
ip for advanced SG zone
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19351/
-----------------------------------------------------------
(Updated March 19, 2014, 11:59 a.m.)
Review request for cloudstack, Abhinandan Prateek and edison su.
Changes
-------
Updated patch to check network for SG support and send SG rules.
Bugs: CLOUDSTACK-6240
https://issues.apache.org/jira/browse/CLOUDSTACK-6240
Repository: cloudstack-git
Description
-------
Updated adding SG rules for nic secondary ips in Advacned SG.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239
api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java 199cf2e
server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 51c93b7
Diff: https://reviews.apache.org/r/19351/diff/
Testing
-------
Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic
Thanks,
Jayapal Reddy