[jira] [Commented] (TAP5-1890) PlaceholderBlock should implement RenderCommand

["Kalle Korhonen (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241525#comment-13241525 ] 

Kalle Korhonen commented on TAP5-1890:
--------------------------------------

Applied to 5.4 trunk. While trivial to apply to 5.3.x branch, not sure if it's critical enough. Any justifications?
                
> PlaceholderBlock should implement RenderCommand
> -----------------------------------------------
>
>                 Key: TAP5-1890
>                 URL: https://issues.apache.org/jira/browse/TAP5-1890
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.2, 5.4
>            Reporter: Dragan Sahpaski
>            Assignee: Kalle Korhonen
>            Priority: Trivial
>              Labels: block, zone
>         Attachments: TAP-1890.patch
>
>
> If we have an empty zone like this:
> <t:zone t:id="myZone" />
> zone.getBody() fails to update the zone in an event handler with the following exception:
> org.apache.tapestry5.ioc.util.UnknownValueException
> A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.
> This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.
> A patch is provided with a test that fails.
> I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.
> Cheers,
> Dragan Sahpaski

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira