You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dennis Lawler <dl...@gmail.com> on 2013/03/10 20:39:02 UTC
Review Request: Fix XS 6.1 Guest OS support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9839/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Current trunk Cloudstack does not provision CentOS 6 guest OS type.
This is because of a minor copy-paste error and an incorrect Guest OS template list.
While I was at it, I fixed up a few other template types to match the current XenServer 6.1 template list.
This addresses bug CLOUDSTACK-1620.
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 1b8496f
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 17ad3e6
Diff: https://reviews.apache.org/r/9839/diff/
Testing
-------
Provisioned CentOS 6 and Ubuntu 12.04 VMs on XS 6.1.
Thanks,
Dennis Lawler
Re: Review Request: Fix XS 6.1 Guest OS support
Posted by Dennis Lawler <dl...@gmail.com>.
> On March 11, 2013, 2:07 a.m., Chip Childers wrote:
> > There are a couple of minor questions I have (see line specific comments). Can you please correct or answer, and then submit a new patch?
Sure, no problem!
> On March 11, 2013, 2:07 a.m., Chip Childers wrote:
> > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java, line 585
> > <https://reviews.apache.org/r/9839/diff/1/?file=268835#file268835line585>
> >
> > Why are you removing Debian Lenny here?
I dropped Lenny because XS 6.1 appears to no longer have that template.
Confirmed via Citrix Guest Support doc here:
http://docs.vmd.citrix.com/XenServer/6.1.0/1.0/en_gb/guest_support_6.1.0.html
Debian Lenny is listed as a Deprecated guest in XS 6.1
So, from what I can tell, the current behavior would cause a failure to deploy that OS type as it would use a template that does not exist. With this change, it should fail to find that guest OS in the map and fall back to "Other install media" (full HVM). Not ideal, but preferable to being broken.
> On March 11, 2013, 2:07 a.m., Chip Childers wrote:
> > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java, lines 668-669
> > <https://reviews.apache.org/r/9839/diff/1/?file=268835#file268835line668>
> >
> > Minor nit, but these should probably be ordered after Ubuntu 10.10.
Agreed.
- Dennis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9839/#review17668
-----------------------------------------------------------
On March 10, 2013, 7:39 p.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9839/
> -----------------------------------------------------------
>
> (Updated March 10, 2013, 7:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Current trunk Cloudstack does not provision CentOS 6 guest OS type.
> This is because of a minor copy-paste error and an incorrect Guest OS template list.
> While I was at it, I fixed up a few other template types to match the current XenServer 6.1 template list.
>
>
> This addresses bug CLOUDSTACK-1620.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 1b8496f
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 17ad3e6
>
> Diff: https://reviews.apache.org/r/9839/diff/
>
>
> Testing
> -------
>
> Provisioned CentOS 6 and Ubuntu 12.04 VMs on XS 6.1.
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Fix XS 6.1 Guest OS support
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9839/#review17668
-----------------------------------------------------------
There are a couple of minor questions I have (see line specific comments). Can you please correct or answer, and then submit a new patch?
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
<https://reviews.apache.org/r/9839/#comment37541>
Why are you removing Debian Lenny here?
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
<https://reviews.apache.org/r/9839/#comment37542>
Minor nit, but these should probably be ordered after Ubuntu 10.10.
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java
<https://reviews.apache.org/r/9839/#comment37543>
I think this is the core of of what you meant to change, and it looks right to me.
- Chip Childers
On March 10, 2013, 7:39 p.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9839/
> -----------------------------------------------------------
>
> (Updated March 10, 2013, 7:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Current trunk Cloudstack does not provision CentOS 6 guest OS type.
> This is because of a minor copy-paste error and an incorrect Guest OS template list.
> While I was at it, I fixed up a few other template types to match the current XenServer 6.1 template list.
>
>
> This addresses bug CLOUDSTACK-1620.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 1b8496f
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 17ad3e6
>
> Diff: https://reviews.apache.org/r/9839/diff/
>
>
> Testing
> -------
>
> Provisioned CentOS 6 and Ubuntu 12.04 VMs on XS 6.1.
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Fix XS 6.1 Guest OS support
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9839/#review17690
-----------------------------------------------------------
Ship it!
Applied to 4.1 (I'll push to master as well):
commit 29ec31c645cbf0fce73f4818a9b53e836d7e6835
Author: Dennis Lawler <dl...@gmail.com>
Date: Sun Mar 10 12:16:37 2013 -0700
CLOUDSTACK-1620: getXenServer602GuestOsType -> getXenServer610GuestOsType Fixing XenServer 6.1 OS types incompatible with XS6.0
Thanks for the patch!
- Chip Childers
On March 11, 2013, 3:11 a.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9839/
> -----------------------------------------------------------
>
> (Updated March 11, 2013, 3:11 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Current trunk Cloudstack does not provision CentOS 6 guest OS type.
> This is because of a minor copy-paste error and an incorrect Guest OS template list.
> While I was at it, I fixed up a few other template types to match the current XenServer 6.1 template list.
>
>
> This addresses bug CLOUDSTACK-1620.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 1b8496f
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 17ad3e6
>
> Diff: https://reviews.apache.org/r/9839/diff/
>
>
> Testing
> -------
>
> Provisioned CentOS 6 and Ubuntu 12.04 VMs on XS 6.1.
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Fix XS 6.1 Guest OS support
Posted by Dennis Lawler <dl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9839/
-----------------------------------------------------------
(Updated March 11, 2013, 3:11 a.m.)
Review request for cloudstack.
Changes
-------
Re-arranged Ubuntu 12.04.
Noticed and fixed "Windows Server 8" -> "Windows Server 2012" to match template name.
Description
-------
Current trunk Cloudstack does not provision CentOS 6 guest OS type.
This is because of a minor copy-paste error and an incorrect Guest OS template list.
While I was at it, I fixed up a few other template types to match the current XenServer 6.1 template list.
This addresses bug CLOUDSTACK-1620.
Diffs (updated)
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 1b8496f
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 17ad3e6
Diff: https://reviews.apache.org/r/9839/diff/
Testing
-------
Provisioned CentOS 6 and Ubuntu 12.04 VMs on XS 6.1.
Thanks,
Dennis Lawler